Skip to content

Commit a4a6cdc

Browse files
authored
Remove condition in docker-login ci (#3776)
* Remove condition in docker-login ci * cargo update parachain * allow deprecated
1 parent 9c150ef commit a4a6cdc

File tree

3 files changed

+392
-418
lines changed

3 files changed

+392
-418
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -551,6 +551,12 @@ jobs:
551551
if: startsWith(runner.name, 'GitHub Actions')
552552
uses: ./.github/actions/disk-cleanup
553553

554+
- name: Dockerhub login
555+
uses: docker/login-action@v3
556+
with:
557+
username: ${{ secrets.DOCKERHUB_USERNAME }}
558+
password: ${{ secrets.DOCKERHUB_PASSWORD }}
559+
554560
- name: Set up Docker Buildx
555561
uses: docker/setup-buildx-action@v3
556562
with:
@@ -570,13 +576,6 @@ jobs:
570576
build-args: |
571577
CARGO_FEATURES=mock-server
572578
573-
- name: Dockerhub login
574-
if: needs.set-condition.outputs.rebuild_omni_executor == 'false'
575-
uses: docker/login-action@v3
576-
with:
577-
username: ${{ secrets.DOCKERHUB_USERNAME }}
578-
password: ${{ secrets.DOCKERHUB_PASSWORD }}
579-
580579
- name: Pull omni-executor image optionally
581580
if: needs.set-condition.outputs.rebuild_omni_executor == 'false'
582581
run: |

0 commit comments

Comments
 (0)