Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiation between different cargo profiles #326

Closed
Kailai-Wang opened this issue Jan 25, 2022 · 8 comments · Fixed by #451
Closed

Differentiation between different cargo profiles #326

Kailai-Wang opened this issue Jan 25, 2022 · 8 comments · Fixed by #451
Assignees
Labels
I2-medium should be completed within 10 working days

Comments

@Kailai-Wang
Copy link
Collaborator

It's mentioned here that using LTO flag would compile into a more efficient binary at the cost of longer compilation time:
paritytech/polkadot#4311
paritytech/substrate#10608

We might want it to build the releasing binary instead using the default release profile.

@Kailai-Wang Kailai-Wang added the I2-medium should be completed within 10 working days label Jan 25, 2022
@geastwood
Copy link

geastwood commented Jan 25, 2022

Is it still experimental, or is it for production?

@Kailai-Wang
Copy link
Collaborator Author

Is it still experimental, or is it for production?

For production, at least moonbeam is already using this in their released binaries.
If polkadot/substrate decides to follow, we could do that too.

@ggwpez
Copy link

ggwpez commented Feb 2, 2022

If polkadot/substrate decides to follow, we could do that too.

Already the case, see paritytech/polkadot#4311 (comment)

@Kailai-Wang
Copy link
Collaborator Author

If polkadot/substrate decides to follow, we could do that too.

Already the case, see paritytech/polkadot#4311 (comment)

Thank you for letting us know, will follow up

@Kailai-Wang
Copy link
Collaborator Author

paritytech/polkadot#4778

@github-actions
Copy link
Contributor

❗ This issue is stale because it has been open for 20 days with no activity.
Remove S2-stale label or update it, otherwise this issue will be closed in 5 days.
@litentry/parachain

@Kailai-Wang Kailai-Wang changed the title Potential optimization with LTO flag Use different cargo profiles for dev and production Apr 11, 2022
@Kailai-Wang
Copy link
Collaborator Author

Extended to 2 days as it involves a differentiation between different cargo profiles
see:
https://doc.rust-lang.org/cargo/reference/profiles.html
https://github.com/paritytech/polkadot/blob/master/Cargo.toml

@Kailai-Wang Kailai-Wang changed the title Use different cargo profiles for dev and production Differentiation between different cargo profiles Apr 11, 2022
@Kailai-Wang
Copy link
Collaborator Author

locally it took me 78min to compile the litentry-collator binary with production profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-medium should be completed within 10 working days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants