-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust tee-worker counterpart of pallet-teebag #2469
Adjust tee-worker counterpart of pallet-teebag #2469
Conversation
cc @jonalvarezz it will be a breaking change for client (SDK) as the pallet/extrinsic interface has changed |
tee-worker/ts-tests/integration-tests/common/utils/assertion.ts
Outdated
Show resolved
Hide resolved
tee-worker/core-primitives/node-api/api-client-extensions/src/pallet_teebag.rs
Outdated
Show resolved
Hide resolved
tee-worker/core-primitives/node-api/api-client-extensions/src/pallet_teebag.rs
Outdated
Show resolved
Hide resolved
fixes P-10 |
The lit-resume-worker test fails at the moment, I created an issue P-501 |
Yes, quite a breaking change. We'd need to put IDH under maintenance for a few minutes before releasing it. Btw, will this be released on the original plan of releasing every 3 weeks? So I can plan the client-sdk update accordingly. |
I'd prefer an ad-hoc release if the next regular release is distant. However, the majority of IDHub colleagues is on vacation next week so maybe we can't do it in a hurry anyway :( |
Well mainly the change from |
We can handle that. It is mostly infrastructure so we can definitely do it on behalf of them. |
Is that one changing names as well? The monitoring service we have relies on it. It'd need update too then |
Yes it's now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Tested locally
Context
Only relevant extrinsics are kept - (so no
shield_funds
andunshield_funs
), enough refactoring.Please review (particularly) the pallet-teebag refactoring and node-api for pallet-teebag storage API access
It's a preparation of P-487 (actually, some code is already removed to make it compile).