Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External link tiptap extension #127

Closed
literakl opened this issue Mar 7, 2021 · 1 comment
Closed

External link tiptap extension #127

literakl opened this issue Mar 7, 2021 · 1 comment
Assignees
Labels
priority: P2 should be fixed type: enhancement New feature or request

Comments

@literakl
Copy link
Owner

literakl commented Mar 7, 2021

List of user supplied Tiptap extensions is in GH issue ueberdosis/tiptap#819

I will need an extension displayed in editor menu that opens a dialog where a user can enter a URL. It will insert new section
with a URL preview:

  • twitter, youtube, instagram and facebook will be
  • other URLs will be rendered as a box with containing URL's page title (static value is enough)

There must be such component. EditorJS has such plugin. See editor-js/embed#37 (comment). We can recycle their business logic. I think they rely on an external JS library that does the rendering.

The harder part will be an integration into our sources because users can edit their blog and we need to redisplay it in the editor again. Shall we save both TipTap source and generated HTML containing the result? Probably.

I think that the result must contain JS code that is responsible for rendering the link. Backend must not generate HTML on fly for each view request.

Please discuss the proposed solution after an analysis before implementation.

@literakl literakl changed the title Twitter link External link tiptap extension Mar 18, 2021
@literakl literakl added the type: enhancement New feature or request label Mar 21, 2021
@literakl literakl assigned literakl and unassigned kotte-sanya Apr 1, 2021
@literakl literakl added the priority: P2 should be fixed label Apr 18, 2021
@literakl
Copy link
Owner Author

Duplicated by #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 should be fixed type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants