Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts & command menu #705

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Conversation

hatemhosny
Copy link
Collaborator

@hatemhosny hatemhosny commented Jan 4, 2025

What type of PR is this? (check all applicable)

  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • ♻️ Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert
  • 🌐 Internationalization / Translation

Description

This PR adds

  • Command menu (Ctrl + K)
  • Many keyboard shortcuts
  • The UI shows the keyboard shortcuts (in title attributes or <kbd> elements)
  • Keyboard shortcut menu showing the full collection of shortcuts

Related Tickets & Documents

as discussed in #630

Mobile & Desktop Screenshots/Recordings

image

image

image

image

image

image

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentations?

TODO: add to features section in docs

  • πŸ““ docs (./docs)
  • πŸ“• storybook (./storybook)
  • πŸ“œ README.md
  • πŸ™… no documentation needed

[optional] Are there any post-merge tasks we need to perform?

translations

@zyf722 @gigamaster
Would you kindly have a look here at your convenience?
I'd like to know your general opinion, opinions about functionality, UI, selection of keyboard shortcuts and obviously if you find any issues.
Thank you.

Copy link

netlify bot commented Jan 4, 2025

βœ… Deploy Preview for livecodes ready!

Name Link
πŸ”¨ Latest commit d6d0c78
πŸ” Latest deploy log https://app.netlify.com/sites/livecodes/deploys/677b0c2d7f27340008b37a2d
😎 Deploy Preview https://deploy-preview-705--livecodes.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2025

Deploying livecodes with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: d6d0c78
Status:Β βœ…Β  Deploy successful!
Preview URL: https://ba4563ff.livecodes.pages.dev
Branch Preview URL: https://keyboard-shortcuts.livecodes.pages.dev

View logs

Copy link

sonarqubecloud bot commented Jan 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≀ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant