Revert "Disable parallel test execution for QUIC and HTTP/3 (dotnet#101569)"

liveans · liveans · commit 5e260c08c734 · 2024-04-26T17:36:32.000+02:00
This reverts commit 009d74e.
diff --git a/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs b/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cookies.cs
@@ -44,7 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki
         private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";
 
         [Fact]
-        public virtual async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
+        public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()
         {
             await LoopbackServerFactory.CreateClientAndServerAsync(
                 async uri =>
diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.AltSvc.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.AltSvc.cs
@@ -29,15 +29,10 @@ private HttpClient CreateHttpClient(Version version)
             return client;
         }
 
-        [ConditionalTheory]
+        [Theory]
         [MemberData(nameof(AltSvcHeaderUpgradeVersions))]
         public async Task AltSvc_Header_Upgrade_Success(Version fromVersion, bool overrideHost)
         {
-            if (UseVersion == HttpVersion30 && fromVersion == HttpVersion.Version11 && overrideHost)
-            {
-                throw new SkipTestException("https://github.com/dotnet/runtime/issues/91757");
-            }
-
             // The test makes a request to a HTTP/1 or HTTP/2 server first, which supplies an Alt-Svc header pointing to the second server.
             using GenericLoopbackServer firstServer =
                 fromVersion.Major switch
diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
@@ -1633,7 +1633,6 @@ public SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http2(ITest
         protected override Version UseVersion => HttpVersion.Version20;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3 : SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength
     {
@@ -4026,51 +4025,41 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2(ITestOutputH
         protected override Version UseVersion => HttpVersion.Version20;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3 : HttpClientHandlerTest
     {
         public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3(ITestOutputHelper output) : base(output) { }
         protected override Version UseVersion => HttpVersion.Version30;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandlerTest_Cookies_Http3 : HttpClientHandlerTest_Cookies
     {
         public SocketsHttpHandlerTest_Cookies_Http3(ITestOutputHelper output) : base(output) { }
         protected override Version UseVersion => HttpVersion.Version30;
-
-        [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/91757")]
-        public override Task GetAsync_DefaultCoookieContainer_NoCookieSent() { return null!; }
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3 : HttpClientHandlerTest_Headers
     {
         public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3(ITestOutputHelper output) : base(output) { }
         protected override Version UseVersion => HttpVersion.Version30;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3 : SocketsHttpHandler_Cancellation_Test
     {
         public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3(ITestOutputHelper output) : base(output) { }
         protected override Version UseVersion => HttpVersion.Version30;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3 : HttpClientHandler_AltSvc_Test
     {
         public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3(ITestOutputHelper output) : base(output) { }
         protected override Version UseVersion => HttpVersion.Version30;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3 : HttpClientHandler_Finalization_Test
     {
@@ -4235,7 +4224,6 @@ public SocketsHttpHandler_RequestContentLengthMismatchTest_Http2(ITestOutputHelp
         protected override Version UseVersion => HttpVersion.Version20;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandler_RequestContentLengthMismatchTest_Http3 : SocketsHttpHandler_RequestContentLengthMismatchTest
     {
@@ -4412,7 +4400,6 @@ public SocketsHttpHandler_SocketsHttpHandler_SecurityTest_Http2(ITestOutputHelpe
         protected override Version UseVersion => HttpVersion.Version20;
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandler_SocketsHttpHandler_SecurityTest_Http3 : SocketsHttpHandler_SecurityTest
     {
@@ -4541,7 +4528,6 @@ await Http11LoopbackServerFactory.Singleton.CreateClientAndServerAsync(async uri
         }
     }
 
-    [Collection(nameof(DisableParallelization))]
     [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]
     public sealed class SocketsHttpHandler_HttpRequestErrorTest_Http30 : SocketsHttpHandler_HttpRequestErrorTest
     {
diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestCollection.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestCollection.cs
@@ -15,7 +15,7 @@
 
 namespace System.Net.Quic.Tests;
 
-[CollectionDefinition(nameof(QuicTestCollection), DisableParallelization = true)]
+[CollectionDefinition(nameof(QuicTestCollection))]
 public unsafe class QuicTestCollection : ICollectionFixture<QuicTestCollection>, IDisposable
 {
     public static bool IsSupported => QuicListener.IsSupported && QuicConnection.IsSupported;

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ private static CookieContainer CreateSingleCookieContainer(Uri uri, string cooki`
`44`	`44`	`private static string GetCookieHeaderValue(string cookieName, string cookieValue) => $"{cookieName}={cookieValue}";`
`45`	`45`
`46`	`46`	`[Fact]`
`47`		`- public virtual async Task GetAsync_DefaultCoookieContainer_NoCookieSent()`
	`47`	`+ public async Task GetAsync_DefaultCoookieContainer_NoCookieSent()`
`48`	`48`	`{`
`49`	`49`	`await LoopbackServerFactory.CreateClientAndServerAsync(`
`50`	`50`	`async uri =>`
Original file line number	Diff line number	Diff line change
`@@ -1633,7 +1633,6 @@ public SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http2(ITest`
`1633`	`1633`	`protected override Version UseVersion => HttpVersion.Version20;`
`1634`	`1634`	`}`
`1635`	`1635`
`1636`		`- [Collection(nameof(DisableParallelization))]`
`1637`	`1636`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`1638`	`1637`	`public sealed class SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength_Http3 : SocketsHttpHandler_HttpClientHandler_MaxResponseHeadersLength`
`1639`	`1638`	`{`
`@@ -4026,51 +4025,41 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2(ITestOutputH`
`4026`	`4025`	`protected override Version UseVersion => HttpVersion.Version20;`
`4027`	`4026`	`}`
`4028`	`4027`
`4029`		`- [Collection(nameof(DisableParallelization))]`
`4030`	`4028`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4031`	`4029`	`public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3 : HttpClientHandlerTest`
`4032`	`4030`	`{`
`4033`	`4031`	`public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3(ITestOutputHelper output) : base(output) { }`
`4034`	`4032`	`protected override Version UseVersion => HttpVersion.Version30;`
`4035`	`4033`	`}`
`4036`	`4034`
`4037`		`- [Collection(nameof(DisableParallelization))]`
`4038`	`4035`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4039`	`4036`	`public sealed class SocketsHttpHandlerTest_Cookies_Http3 : HttpClientHandlerTest_Cookies`
`4040`	`4037`	`{`
`4041`	`4038`	`public SocketsHttpHandlerTest_Cookies_Http3(ITestOutputHelper output) : base(output) { }`
`4042`	`4039`	`protected override Version UseVersion => HttpVersion.Version30;`
`4043`		`-`
`4044`		`- [Fact]`
`4045`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/91757")]`
`4046`		`- public override Task GetAsync_DefaultCoookieContainer_NoCookieSent() { return null!; }`
`4047`	`4040`	`}`
`4048`	`4041`
`4049`		`- [Collection(nameof(DisableParallelization))]`
`4050`	`4042`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4051`	`4043`	`public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3 : HttpClientHandlerTest_Headers`
`4052`	`4044`	`{`
`4053`	`4045`	`public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3(ITestOutputHelper output) : base(output) { }`
`4054`	`4046`	`protected override Version UseVersion => HttpVersion.Version30;`
`4055`	`4047`	`}`
`4056`	`4048`
`4057`		`- [Collection(nameof(DisableParallelization))]`
`4058`	`4049`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4059`	`4050`	`public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3 : SocketsHttpHandler_Cancellation_Test`
`4060`	`4051`	`{`
`4061`	`4052`	`public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3(ITestOutputHelper output) : base(output) { }`
`4062`	`4053`	`protected override Version UseVersion => HttpVersion.Version30;`
`4063`	`4054`	`}`
`4064`	`4055`
`4065`		`- [Collection(nameof(DisableParallelization))]`
`4066`	`4056`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4067`	`4057`	`public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3 : HttpClientHandler_AltSvc_Test`
`4068`	`4058`	`{`
`4069`	`4059`	`public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3(ITestOutputHelper output) : base(output) { }`
`4070`	`4060`	`protected override Version UseVersion => HttpVersion.Version30;`
`4071`	`4061`	`}`
`4072`	`4062`
`4073`		`- [Collection(nameof(DisableParallelization))]`
`4074`	`4063`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4075`	`4064`	`public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3 : HttpClientHandler_Finalization_Test`
`4076`	`4065`	`{`
`@@ -4235,7 +4224,6 @@ public SocketsHttpHandler_RequestContentLengthMismatchTest_Http2(ITestOutputHelp`
`4235`	`4224`	`protected override Version UseVersion => HttpVersion.Version20;`
`4236`	`4225`	`}`
`4237`	`4226`
`4238`		`- [Collection(nameof(DisableParallelization))]`
`4239`	`4227`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4240`	`4228`	`public sealed class SocketsHttpHandler_RequestContentLengthMismatchTest_Http3 : SocketsHttpHandler_RequestContentLengthMismatchTest`
`4241`	`4229`	`{`
`@@ -4412,7 +4400,6 @@ public SocketsHttpHandler_SocketsHttpHandler_SecurityTest_Http2(ITestOutputHelpe`
`4412`	`4400`	`protected override Version UseVersion => HttpVersion.Version20;`
`4413`	`4401`	`}`
`4414`	`4402`
`4415`		`- [Collection(nameof(DisableParallelization))]`
`4416`	`4403`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4417`	`4404`	`public sealed class SocketsHttpHandler_SocketsHttpHandler_SecurityTest_Http3 : SocketsHttpHandler_SecurityTest`
`4418`	`4405`	`{`
`@@ -4541,7 +4528,6 @@ await Http11LoopbackServerFactory.Singleton.CreateClientAndServerAsync(async uri`
`4541`	`4528`	`}`
`4542`	`4529`	`}`
`4543`	`4530`
`4544`		`- [Collection(nameof(DisableParallelization))]`
`4545`	`4531`	`[ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsQuicSupported))]`
`4546`	`4532`	`public sealed class SocketsHttpHandler_HttpRequestErrorTest_Http30 : SocketsHttpHandler_HttpRequestErrorTest`
`4547`	`4533`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`namespace System.Net.Quic.Tests;`
`17`	`17`
`18`		`-[CollectionDefinition(nameof(QuicTestCollection), DisableParallelization = true)]`
	`18`	`+[CollectionDefinition(nameof(QuicTestCollection))]`
`19`	`19`	`public unsafe class QuicTestCollection : ICollectionFixture<QuicTestCollection>, IDisposable`
`20`	`20`	`{`
`21`	`21`	`public static bool IsSupported => QuicListener.IsSupported && QuicConnection.IsSupported;`