Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drag and drop in a notebook to upload to a particular storage #2498

Closed
josevalim opened this issue Feb 27, 2024 · 2 comments · Fixed by #2868
Closed

Allow drag and drop in a notebook to upload to a particular storage #2498

josevalim opened this issue Feb 27, 2024 · 2 comments · Fixed by #2868
Labels
feature New feature or request

Comments

@josevalim
Copy link
Contributor

Currently it is always an attachment, but we could choose "Upload to storage and store link".

@jonatanklosko
Copy link
Member

jonatanklosko commented Nov 22, 2024

This can already be achieved by drag-and-dropping into the file navigator here:

image

When dropping a file in the notebook, we show "From upload" tab with the file selected. We could add a radio, but then we need to conditionally show the navigator, so the user can select the storage and path.

I think ideally we should avoid duplicated workflows, because the "Add file" modal already has a bunch of variants. Instead, we could show a tip like this:

image

WDYT?

@josevalim
Copy link
Contributor Author

Sounds great! I would just say:

This will upload the file as an attachment in the notebook /files directory. If you want to upload it to a file storage instead, choose "From storage", then drag and drop the file to the desired storage and directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants