Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte.js not found (appeared after 0.2.2) #226

Closed
jfmario opened this issue Jul 22, 2022 · 4 comments · Fixed by #228
Closed

svelte.js not found (appeared after 0.2.2) #226

jfmario opened this issue Jul 22, 2022 · 4 comments · Fixed by #228

Comments

@jfmario
Copy link
Contributor

jfmario commented Jul 22, 2022

To reproduce: go to a pre-existing project, install the latest release of bud, and run bud build.

My error is:

../go/pkg/mod/github.com/livebud/bud@v0.2.2/framework/view/ssr/ssr.go:279:12: pattern svelte.js: no matching files found

The offending part of ssr.go is:

//go:embed svelte.js
var svelteRuntime string

There is no svelte.js in that directory, and I don;t think there was before. It used to be //go:embed svelte.ts.

I'd do a PR, but I'm thinking you made this change for a reason and something didn't make it into the repo?

@jfmario
Copy link
Contributor Author

jfmario commented Jul 22, 2022

I don't have this error when running go run main.go -C ../bud-sample-1/ build. My local bud repo got its svelte.js at some point.

@matthewmueller
Copy link
Contributor

matthewmueller commented Jul 22, 2022

Ah shoot. I knew there was a reason for keeping these files in source control.

Ideally, they stay out of source control, but get embedded during release. I'm not sure how to do that right now though.

I'll get this fixed one way or another tonight and cut a new release. Sorry about this regression! In the meantime, you can downgrade to v0.2.1 with:

curl -sf https://raw.githubusercontent.com/livebud/bud/main/install.sh | VERSION=v0.2.1 sh

I've also been meaning to add some basic black-box tests to the Makefile, similar to what esbuild does, that we can run in CI.

@pacholoamit
Copy link

Hello! Was facing the same issue but when I ran the script with the VERSION above it works!

@matthewmueller
Copy link
Contributor

Fixed in v0.2.3! Upgrade with:

curl -sf https://raw.githubusercontent.com/livebud/bud/main/install.sh | sh

Sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants