Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Date picker to new repository [DS-165] #284

Closed
skrabkab-design opened this issue Oct 29, 2021 · 3 comments
Closed

Move Date picker to new repository [DS-165] #284

skrabkab-design opened this issue Oct 29, 2021 · 3 comments
Assignees

Comments

@skrabkab-design
Copy link

skrabkab-design commented Oct 29, 2021

We're aiming to move this component to Storybook

To do:

  • Make sure to use appropriate typography tokens (see other components for reference – like Card or Radio button),
  • Make sure to use color tokens - Figma
  • Make sure to use appropriate icons from the DS icon package,
  • Introduce small visual tweaks Figma
  • Remove option to enter custom date manually in this type of date picker https://tppr.me/dww7X using inputs inside select looks pretty weird, we're also not using this pattern in AA, so looks like this exists only in DS,
@skrabkab-design
Copy link
Author

We can also think about updating package to newest version of http://react-day-picker.js.org/changelog
@przemuh will that make sense here?

@kamilmateusiak
Copy link
Contributor

kamilmateusiak commented Mar 4, 2022

Hello. I am sorry for no info about work status for so long (I've had some personal stuff happening). Currently I have some free time and the component migration is almost done. Unfortunately I don't have access to the repository. nvm I forked repository and I was able to make a PR.

If you didn't start the work on that yet and you are still interested in external contribution please add me as contributor to the repository.

@sgraczyk
Copy link

Canceled in favor of #331

@sgraczyk sgraczyk closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants