-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video support #24
Comments
Hi @Hollymingyi would you mind explaining what you are doing more? what SIP client are you using? Do you need the SIP server to mix video, or can it be delivered as separate media sections? |
hi sean, after all ,i want sip server to mix video into likekit room ,and separate media back to freeswitch. |
You are trying to connect Freeswitch + LiveKit? Why are you running both servers? Would it be possible to only run one? What features are missing from either? It would probably be more effective to use egress. That has composition and has more flexibility. If you can describe exactly what you are trying to build we would love to help! |
|
The most important detail is missing from the diagram - who is making SIP video call? How it produces and consumes video streams? Sean is right to point out that passing |
hi dennwc, |
OK, got it. To emphasize, we don't have any plans to implement video for SIP. However, if this turns out to be simple enough (e.g. pick one participant/egress, stream from it), then I might experiment with it when I have some free time. There might be additional constraints here. For audio, we convert Ulaw <-> Opus in SIP server. If there's similar mismatch between video formats in SIP and LK, that will be a blocker. We definitely won't convert video in SIP server. |
ah ,thanks anyway, our application wanna have video communication between sip and livekit, so i would prefer to get egress media from lk and then push it back to sip server (the sip invite have sdp,) via mediaconn. could u help to give me a plan or workflow to coding them? |
Closing as we do not plan to support video with SIP. |
hi david, 2023-12-22T14:45:02.275+0800 INFO livekit.pub.sfu buffer/rtpstats_receiver.go:306 received sender report, out-of-order, resetting{"room": "91233445", "roomID": "RM_QCzP286EekLz", "participant": "Phone 89650050", "pID": "PA_L7PCC44n6mYa", "remote": false, "trackID": "TR_VCeqyecBzUPLHs", "relayed": false, "mime": "video/h264", "layer": 0, "last": "ntp: 2023-12-22 06:45:01.273902416 +0000 UTC, rtp: 1954390734, extRtp: 1954390734, at: 2023-12-22 14:45:01.274211609 +0800 CST m=+2591.952357079", "current": "ntp: 2023-12-22 06:45:02.274554252 +0000 UTC, rtp: 1954390045, extRtp: 1954390045, at: 2023-12-22 14:45:02.275287018 +0800 CST m=+2592.953432502", "count": 300} is it something wrong? |
Hey @Hollymingyi, if it's a general enquiry, please ask folks in our Slack community. I'm not able to tell what's happening based on limited logs. |
hi david, |
hi david, the other payload type or profile-level-id cant work. |
+1 |
This comes up quite frequently, so we would like to clarify the current state of the issue. Current stateVideo support for LiveKit SIP was considered, but we don't have a specific plan for it yet. LiveKit team is currently focused on other issues with higher priority. BlockersThe reasons why we think it couldn't be implemented fast enough is: Multiple participantsLiveKit rooms typically contain multiple participants, while SIP usually support only one video stream per call. This means that LiveKit SIP will have to mix video frames from the participants somehow. This is not trivial.
Supported codecsLiveKit currently supports the following codecs. We will have to either enforce selected codecs or transcode video in LK SIP.
ImplementationFor anyone planning to contribute SIP video support, please consider the following:
There's already a PR for an older LK SIP version which could act as a starting point: #35 Hope this resolves some of the questions regarding this issue. We are open to a discussion and/or contributions! |
SIP video support is important for deployment in organizations with a lot of existing video conferencing hardware. |
dear author,
could u help to telll me how to pull video meida from sip server and push video media to sip server? or do u have the plan to support video with sip module?
The text was updated successfully, but these errors were encountered: