Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding deployment requires npm install/update #6

Open
sylvain-morin opened this issue Feb 17, 2022 · 3 comments
Open

Branding deployment requires npm install/update #6

sylvain-morin opened this issue Feb 17, 2022 · 3 comments

Comments

@sylvain-morin
Copy link

Branding deployment is failing because some npm libs are missing.

Executing:
npm install npm update

is fixing the issue.

It would be great to have it executed by default

@vjrj
Copy link
Contributor

vjrj commented Feb 17, 2022

Thanks indeed @sylmorin-gbif.

I think that this issue is something weird that happens because we are using a docker environment (and BTW didn't happened to me before, only to other users).

The deploy script is this:
https://github.com/living-atlases/generator-living-atlas/blob/master/generators/app/templates/deploy-branding.sh
and yarn install should install the deps.

Some related discussion:
https://atlaslivingaustralia.slack.com/archives/CCTFGEU1G/p1637074047119100?thread_ts=1635761393.047800&cid=CCTFGEU1G

I thought this was fixed already with this commit:
dc655e9
but as this is something that I cannot reproduce, I'm trying to fix reading about similar issues in the net, ...

Did you exec npm install from the console?

@sylvain-morin
Copy link
Author

I totally used the slack discussion you mentioned to fix my issue :)
Executing the npm install from the console (so, inside the docker container)

By the way (since I prepared my demo, I rehearsed serveral times), once, I did the npm install from my laptop, in the branding config directory - but not from the docker container

What a mistake !!! since my local npm version was not the same than the npm in the docker container, everything was messy after that...

That's why it would be great if the deploy script could execute it, from the docker container, don't you think?

@vjrj
Copy link
Contributor

vjrj commented May 10, 2022

I still cannot reproduce, I tried several deployments and all worked for me.

image

Probably related:

I do npm install (for things not related with the branding) and yarn install for the branding inside the Dockerfile so the deps should be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants