Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional delim argument #12

Merged
merged 1 commit into from
Aug 7, 2014
Merged

Add optional delim argument #12

merged 1 commit into from
Aug 7, 2014

Conversation

mjackson
Copy link
Contributor

@mjackson mjackson commented Aug 7, 2014

This is useful for parsing/stringifying cookie values.

@mjackson
Add optional delim argument
a381a4b 
This is useful for parsing/stringifying cookie values.
nlf added a commit that referenced this pull request Aug 7, 2014
@nlf
Merge pull request #12 from mjackson/opt-delim
79072c4 
Add optional delim argument
@nlf nlf merged commit 79072c4 into ljharb:master Aug 7, 2014
@nlf nlf added the enhancement label Aug 7, 2014
@nlf nlf added this to the 1.1.1 milestone Aug 7, 2014
@nlf nlf self-assigned this Aug 7, 2014
nlf added a commit that referenced this pull request Aug 7, 2014
@nlf
cleanup for #12
0676904
@nlf
Copy link
Collaborator

nlf commented Aug 7, 2014

Thanks! Published in v1.2.0

@mjackson
Copy link
Contributor Author

mjackson commented Aug 7, 2014

@nlf So quick! :D You're welcome

mjackson added a commit to mjackson/qs that referenced this pull request Aug 25, 2014
@mjackson
Enable using a RegExp as delimiter
870577e 
This fixes a regression that was introduced in ljharb#16 which prevents
anything but a string from being used as a delimiter. But the whole
point of ljharb#12 was to allow users to specify a RegExp to use in
queryString.split(delimiter).
@mjackson mjackson mentioned this pull request Aug 25, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlf nlf

Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mjackson @nlf