-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusion in the README #4
Comments
Also, the main pokeGAN.py is resizing the images as well (to 128x128). So the resize and rgb scripts are not really needed I guess. |
I found this confusing as well! And also I found that the provided images of the data folder are also of two shapes. Some are 1280x1280 and some are 431x431. No clue why this is and if it affects the code. |
The input images will be scaled using tensorflow functions. Size of input doesn't matter. I guess in the first version they were scaled in pre-proccessing. And of course the input pipeline is faster, if the images don't need to be scaled. |
I am getting following error while executing pokeGAN.py (log below). Any clues?
|
Readme says that before running
pokeGAN.py
one should runresize.py
andRGBA2RGB.py
.There are few problems here and I'll work backwards from
pokeGAN.py
to explain them. InpokeGAN.py
the height and width of the images are hardcoded to be 128 and 128. However inresize.py
resized images height and width are 256. This is the first wtf.Second wtf is that
pokeGAN.py
reads the data from 'data' directory (line 29), butresize.py
puts data in a directory named 'resizedData'. Third thing is thatRGBA2RGB.py
takes this a step further and puts files from resizedData to resized_black (which is bad naming, but let it be).To conclude, either the
pokeGAN.py
reads images from wrong directories or helper scripts put processed images into wrong directories. I understand that this is not your code, but let's fix this if people of YouTube will try to use it 😉The text was updated successfully, but these errors were encountered: