Skip to content

Conversation

mhdawson
Copy link
Contributor

- without this change the secret must also be provided
  in the llama-stack environment which too me a little
  while to figure out
- makes it a bit more consistent with the python example in
  https://github.com/meta-llama/llama-stack-apps/blob/592a101c155082125d8f1170cf4824860a0fd921/examples/agents/hello.py#L24

Signed-off-by: Michael Dawson <midawson@redhat.com>
@facebook-github-bot
Copy link
Contributor

Hi @mhdawson!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@mhdawson
Copy link
Contributor Author

Signed the CLA

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 25, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mhdawson
Copy link
Contributor Author

Let me know if there is anything I need to do in order for this to move forward.

@mhdawson
Copy link
Contributor Author

Just checking if there is anything more I need to do before this can land?

@ashwinb ashwinb merged commit b86d1da into llamastack:main Apr 25, 2025
1 check passed
@stainless-app stainless-app bot mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants