Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Python3.12 compatibility #2938

Closed
1 task done
9er opened this issue May 17, 2024 · 8 comments
Closed
1 task done

[Feature Request]: Python3.12 compatibility #2938

9er opened this issue May 17, 2024 · 8 comments
Labels
enhancement New feature or request package change This PR introduces changes to packages
Milestone

Comments

@9er
Copy link

9er commented May 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

I tried installing the PIP requirements with python 3.12.3, but it fails in several places. I have upped some packages:

-pyyaml==6.0
+pyyaml==6.0.1

-scipy==1.9.3
+scipy==1.11.4

-onnxruntime==1.16.3
+onnxruntime==1.17.3

The first one is already in #2927.

And I get much further, but then cargo explodes

      error: `cargo rustc --lib --message-format=json-render-diagnostics --manifest-path Cargo.toml --release -v --features pyo3/extension-module --crate-type cdylib --` failed with code 101

So here I'm out of ideas. I assume that there are some fixes neccessary for python 3.12 and that someone is smarter than me and knows what to do :)

Proposed workflow

(there's documentation for installing Fooocus, so it should work with recent python versions)

Additional information

No response

@9er 9er added enhancement New feature or request triage This needs an (initial) review labels May 17, 2024
@blckbx
Copy link

blckbx commented May 17, 2024

See my working config here: mashb1t#19 (comment)

@9er
Copy link
Author

9er commented May 17, 2024

That works! I have checked existing issues, PRs and branches, but not discussions 🙃

@blckbx
Copy link

blckbx commented May 17, 2024

Yeah, been tinkering with mashbit's fork and got it working on Ubuntu 24.04 this way. But I guess it depends on availability of python packages (pypi access especially from China) as he mentioned.
Hint: Make a backup of requirements_versions.txt because it will be replaced on every update until this repo is updated to fix Python 3.12 dependencies.

@mashb1t
Copy link
Collaborator

mashb1t commented May 17, 2024

Please check out the fixed versions of #2927, as it's always better to pin versions, especially for security and / or bundling via zip file.
Feedback would highly be appreciated.

@mashb1t mashb1t added this to the package updates milestone May 17, 2024
@blckbx
Copy link

blckbx commented May 17, 2024

Please check out the fixed versions of #2927, as it's always better to pin versions, especially for security and / or bundling via zip file.
Feedback would highly be appreciated.

This is not enough for Python 3.12. pip install -r requirements_versions.txt exits building package "pillow".

Building wheels for collected packages: Pillow
  Building wheel for Pillow (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for Pillow (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [201 lines of output]
...
  ERROR: Failed building wheel for Pillow

Tested Pillow versions up till success. Min version required is 10.0.0

Long story short: With Pillow==10.0.0 #2927 also builds on Python 3.12.

@mashb1t mashb1t removed the triage This needs an (initial) review label May 17, 2024
@mashb1t mashb1t mentioned this issue Jun 13, 2024
5 tasks
@mashb1t mashb1t added the package change This PR introduces changes to packages label Jun 13, 2024
@cootshk
Copy link

cootshk commented Jun 18, 2024

Will be fixed in #2927 - if you want to use it now, download the updated branch @ cootshk/Fooocus

@ricperry
Copy link

ricperry commented Jul 1, 2024

When I update the requirements_versions.txt with >= instead of == (except for gradio, leave that one ==), then I got it to work.

@mashb1t mashb1t modified the milestones: package updates, v2.5.0 Jul 16, 2024
@mashb1t mashb1t linked a pull request Jul 16, 2024 that will close this issue
@mashb1t
Copy link
Collaborator

mashb1t commented Jul 16, 2024

General support has been established, but see #2927 (comment)

@mashb1t mashb1t closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package change This PR introduces changes to packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants