Merge pull request #350 from lloc/refactoring-2-9

Escaping

Author: lloc

includes/MslsAdmin.php

@@ -172,12 +172,13 @@ public function render(): void {
 		settings_fields( 'msls' );
 		do_settings_sections( __CLASS__ );
 
+		$value = $this->options->is_empty() ?
+			__( 'Configure', 'multisite-language-switcher' ) :
+			__( 'Update', 'multisite-language-switcher' );
+
 		printf(
 			'<p class="submit"><input name="Submit" type="submit" class="button button-primary" value="%s" /></p></form></div>',
-			( $this->options->is_empty() ? __( 'Configure', 'multisite-language-switcher' ) : __(
-				'Update',
-				'multisite-language-switcher'
-			) )
+			esc_html( $value )
 		);
 	}
 

includes/MslsCustomColumn.php

@@ -100,9 +100,11 @@ public function td( $column_name, $item_id ) {
 						$icon->set_href( (int) $mydata->$language );
 					}
 
-					echo '<span class="msls-icon-wrapper ' . esc_attr( $this->options->admin_display ) . '">';
-					echo $icon->get_a();
-					echo '</span>';
+					printf(
+						'<span class="msls-icon-wrapper %1$s">%2$s</span>',
+						esc_attr( $this->options->admin_display ),
+						$icon->get_a()
+					);
 
 					restore_current_blog();
 				}