Skip to content

Commit 097f1e7

Browse files
authored
[lldb] Do not stop the process on SIGWINCH by default. (#163182)
SIGWINCH is sent when the terminal window size changes.. Most people debugging do not want the process on this signal. When using lldb-dap, the user may be using an integrated terminal and may resize the pane/window mulitple times when debugging. this causes the signal to be sent multiple times. It gets in the way. The process ignores this signal by default
1 parent c89d721 commit 097f1e7

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

lldb/source/Plugins/Process/Utility/GDBRemoteSignals.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ void GDBRemoteSignals::Reset() {
4747
AddSignal(25, "SIGXFSZ", false, true, true, "file size limit exceeded");
4848
AddSignal(26, "SIGVTALRM", false, true, true, "virtual time alarm");
4949
AddSignal(27, "SIGPROF", false, false, false, "profiling time alarm");
50-
AddSignal(28, "SIGWINCH", false, true, true, "window size changes");
50+
AddSignal(28, "SIGWINCH", false, false, false, "window size changes");
5151
AddSignal(29, "SIGLOST", false, true, true, "resource lost");
5252
AddSignal(30, "SIGUSR1", false, true, true, "user defined signal 1");
5353
AddSignal(31, "SIGUSR2", false, true, true, "user defined signal 2");

lldb/source/Plugins/Process/Utility/LinuxSignals.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ void LinuxSignals::Reset() {
160160
ADD_LINUX_SIGNAL(25, "SIGXFSZ", false, true, true, "file size limit exceeded");
161161
ADD_LINUX_SIGNAL(26, "SIGVTALRM", false, true, true, "virtual time alarm");
162162
ADD_LINUX_SIGNAL(27, "SIGPROF", false, false, false, "profiling time alarm");
163-
ADD_LINUX_SIGNAL(28, "SIGWINCH", false, true, true, "window size changes");
163+
ADD_LINUX_SIGNAL(28, "SIGWINCH", false, false, false, "window size changes");
164164
ADD_LINUX_SIGNAL(29, "SIGIO", false, true, true, "input/output ready/Pollable event", "SIGPOLL");
165165
ADD_LINUX_SIGNAL(30, "SIGPWR", false, true, true, "power failure");
166166
ADD_LINUX_SIGNAL(31, "SIGSYS", false, true, true, "invalid system call");

llvm/docs/ReleaseNotes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,9 @@ Changes to LLDB
176176

177177
* LLDB can now set breakpoints, show backtraces, and display variables when
178178
debugging Wasm with supported runtimes (WAMR and V8).
179+
* LLDB no longer stops processes by default when receiving SIGWINCH signals
180+
(window resize events) on Linux. This is the default on other Unix platforms.
181+
You can re-enable it using `process handle --notify=true --stop=true SIGWINCH`.
179182
* The `show-progress` setting, which became a NOOP with the introduction of the
180183
statusline, now defaults to off and controls using OSC escape codes to show a
181184
native progress bar in supporting terminals like Ghostty and ConEmu.

0 commit comments

Comments
 (0)