Skip to content

Commit 1e3bc8b

Browse files
committed
llvm-reduce: Fix losing operand bundles when removing arguments
1 parent 115a77d commit 1e3bc8b

File tree

2 files changed

+32
-2
lines changed

2 files changed

+32
-2
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
; Check that when removing arguments, existing bundles are preserved
2+
3+
; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=arguments --test FileCheck --test-arg --check-prefixes=INTERESTING --test-arg %s --test-arg --input-file %s -o %t
4+
; RUN: FileCheck --check-prefixes=RESULT %s < %t
5+
6+
; INTERESTING-LABEL: @convergent_callee(
7+
define i32 @convergent_callee(i32 %a, i32 %b) convergent {
8+
ret i32 %a
9+
}
10+
11+
; INTERESTING-LABEL: @convergent_callee_decl(
12+
declare i32 @convergent_callee_decl(i32 %a, i32 %b) convergent
13+
14+
; INTERESTING-LABEL: @convergent_caller(
15+
; INTERESTING: call i32
16+
; INTERESTING: call i32
17+
18+
; RESULT-LABEL: define i32 @convergent_caller()
19+
; RESULT: %call0 = call i32 @convergent_callee() [ "convergencectrl"(token %entry.token) ]
20+
; RESULT: %call1 = call i32 @convergent_callee_decl() [ "convergencectrl"(token %entry.token) ]
21+
define i32 @convergent_caller(i32 %x) convergent {
22+
%entry.token = call token @llvm.experimental.convergence.entry()
23+
%call0 = call i32 @convergent_callee(i32 %x, i32 2) [ "convergencectrl"(token %entry.token) ]
24+
%call1 = call i32 @convergent_callee_decl(i32 %x, i32 2) [ "convergencectrl"(token %entry.token) ]
25+
%result = add i32 %call0, %call1
26+
ret i32 %result
27+
}
28+

Diff for: llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,10 @@ static void replaceFunctionCalls(Function &OldF, Function &NewF,
6161
}
6262
}
6363

64-
// FIXME: Losing bundles
65-
CallInst *NewCI = CallInst::Create(&NewF, Args);
64+
SmallVector<OperandBundleDef, 2> OpBundles;
65+
CI->getOperandBundlesAsDefs(OpBundles);
66+
67+
CallInst *NewCI = CallInst::Create(&NewF, Args, OpBundles);
6668
NewCI->setCallingConv(NewF.getCallingConv());
6769

6870
AttrBuilder CallSiteAttrs(Ctx, CI->getAttributes().getFnAttrs());

0 commit comments

Comments
 (0)