fix clang static analyzer and functions checker

Author: Zishan Mirza

clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp

@@ -3578,13 +3578,13 @@ void StdLibraryFunctionsChecker::initFunctionSummaries(
     addToFunctionSummaryMap(
         "ctime_s",
         Signature(ArgTypes{CharPtrTy,
-                           BufferSize(ArgNo(1), BVF.getValue(26, IntTy)),
+                           BufferSize(ArgNo(0), BVF.getValue(26, IntTy)),
                            ConstTime_tPtrTy},
                   RetType{CharPtrTy}),
         Summary(NoEvalCall)
             .ArgConstraint(NotNull(ArgNo(0)))
             .ArgConstraint(BufferSize(
-                /*Buffer=*/ArgNo(1),
+                /*Buffer=*/ArgNo(0),
                 /*MinBufSize=*/BVF.getValue(26, IntTy))));
     .ArgConstraint(NotNull(ArgNo(2)))
 

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc

@@ -1439,7 +1439,7 @@ INTERCEPTOR(char *, ctime_s, char *result, size_t result_size,
   // FIXME: under ASan the call below may write to freed memory and corrupt
   // its metadata. See
   // https://github.com/google/sanitizers/issues/321.
-  char *res = REAL(ctime_r)(result, result_size, timep);
+  char *res = REAL(ctime_s)(result, result_size, timep);
   if (res) {
     COMMON_INTERCEPTOR_READ_RANGE(ctx, timep, sizeof(*timep));
     COMMON_INTERCEPTOR_WRITE_RANGE(ctx, res, internal_strlen(res) + 1);