[llvm-remarkutil] Silence a GCC warning about missing returns after a fully covered switch. NFC.

mstorsjo · mstorsjo · commit 4f4694509d29 · 2023-10-13T10:33:17.000+03:00
diff --git a/llvm/tools/llvm-remarkutil/RemarkCounter.cpp b/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
@@ -181,6 +181,7 @@ std::optional<std::string> Counter::getGroupByKey(const Remark &Remark) {
       return Remark.Loc->SourceFilePath.str() + ":" + Remark.FunctionName.str();
     return Remark.Loc->SourceFilePath.str();
   }
+  llvm_unreachable("Fully covered switch above!");
 }
 
 void ArgumentCounter::collect(const Remark &Remark) {

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,7 @@ std::optional<std::string> Counter::getGroupByKey(const Remark &Remark) {`
`181`	`181`	`return Remark.Loc->SourceFilePath.str() + ":" + Remark.FunctionName.str();`
`182`	`182`	`return Remark.Loc->SourceFilePath.str();`
`183`	`183`	`}`
	`184`	`+ llvm_unreachable("Fully covered switch above!");`
`184`	`185`	`}`
`185`	`186`
`186`	`187`	`void ArgumentCounter::collect(const Remark &Remark) {`