Skip to content

Commit 9df06bb

Browse files
committed
[AArch64][SVE] Used fixed width vectorizatio for A510 and A520
Inefficient SVE codegen occurs on at least two in-order cores, those being Cortex-A510 and Cortex-A520. For example a simple vector add ``` void foo(float a, float b, float dst, unsigned n) { for (unsigned i = 0; i < n; ++i) dst[i] = a[i] + b[i]; } ``` Vectorizes the inner loop into the following interleaved sequence of instructions. ``` add x12, x1, x10 ld1b { z0.b }, p0/z, [x1, x10] add x13, x2, x10 ld1b { z1.b }, p0/z, [x2, x10] ldr z2, [x12, #1, mul vl] ldr z3, [x13, #1, mul vl] dech x11 add x12, x0, x10 fadd z0.s, z1.s, z0.s fadd z1.s, z3.s, z2.s st1b { z0.b }, p0, [x0, x10] addvl x10, x10, #2 str z1, [x12, #1, mul vl] ``` By adjusting the target features to prefer fixed over scalable if the cost is equal we get the following vectorized loop. ``` ldp q0, q3, [x11, #-16] subs x13, x13, #8 ldp q1, q2, [x10, #-16] add x10, x10, #32 add x11, x11, #32 fadd v0.4s, v1.4s, v0.4s fadd v1.4s, v2.4s, v3.4s stp q0, q1, [x12, #-16] add x12, x12, #32 ``` Which is more efficient. Change-Id: Ie1e862f6a1db851182a95534b3b987feb670d7ca
1 parent 64555e3 commit 9df06bb

File tree

2 files changed

+172
-0
lines changed

2 files changed

+172
-0
lines changed

llvm/lib/Target/AArch64/AArch64Processors.td

+2
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,7 @@ def ProcessorFeatures {
712712
FeatureSB, FeaturePAuth, FeatureSSBS, FeatureSVE, FeatureSVE2,
713713
FeatureComplxNum, FeatureCRC, FeatureDotProd,
714714
FeatureFPARMv8,FeatureFullFP16, FeatureJS, FeatureLSE,
715+
FeatureUseFixedOverScalableIfEqualCost,
715716
FeatureRAS, FeatureRCPC, FeatureRDM];
716717
list<SubtargetFeature> A520 = [HasV9_2aOps, FeaturePerfMon, FeatureAM,
717718
FeatureMTE, FeatureETE, FeatureSVEBitPerm,
@@ -721,6 +722,7 @@ def ProcessorFeatures {
721722
FeatureSVE, FeatureSVE2, FeatureBF16, FeatureComplxNum, FeatureCRC,
722723
FeatureFPARMv8, FeatureFullFP16, FeatureMatMulInt8, FeatureJS,
723724
FeatureNEON, FeatureLSE, FeatureRAS, FeatureRCPC, FeatureRDM,
725+
FeatureUseFixedOverScalableIfEqualCost,
724726
FeatureDotProd];
725727
list<SubtargetFeature> A520AE = [HasV9_2aOps, FeaturePerfMon, FeatureAM,
726728
FeatureMTE, FeatureETE, FeatureSVEBitPerm,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,170 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt < %s -mtriple=aarch64-none-elf -mcpu=cortex-a510 -mattr=+sve -passes=loop-vectorize -S | FileCheck %s --check-prefix=CHECK-CA510
3+
; RUN: opt < %s -mtriple=aarch64-none-elf -mcpu=cortex-a520 -mattr=+sve -passes=loop-vectorize -S | FileCheck %s --check-prefix=CHECK-CA520
4+
5+
define void @sve_add(ptr %dst, ptr %a, ptr %b, i64 %n) {
6+
; CHECK-CA510-LABEL: define void @sve_add(
7+
; CHECK-CA510-SAME: ptr [[DST:%.*]], ptr [[A:%.*]], ptr [[B:%.*]], i64 [[N:%.*]]) #[[ATTR0:[0-9]+]] {
8+
; CHECK-CA510-NEXT: [[ENTRY:.*:]]
9+
; CHECK-CA510-NEXT: [[B3:%.*]] = ptrtoint ptr [[B]] to i64
10+
; CHECK-CA510-NEXT: [[A2:%.*]] = ptrtoint ptr [[A]] to i64
11+
; CHECK-CA510-NEXT: [[DST1:%.*]] = ptrtoint ptr [[DST]] to i64
12+
; CHECK-CA510-NEXT: [[CMP9_NOT:%.*]] = icmp eq i64 [[N]], 0
13+
; CHECK-CA510-NEXT: br i1 [[CMP9_NOT]], label %[[FOR_COND_CLEANUP:.*]], label %[[FOR_BODY_PREHEADER:.*]]
14+
; CHECK-CA510: [[FOR_BODY_PREHEADER]]:
15+
; CHECK-CA510-NEXT: [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[N]], 8
16+
; CHECK-CA510-NEXT: br i1 [[MIN_ITERS_CHECK]], label %[[SCALAR_PH:.*]], label %[[VECTOR_MEMCHECK:.*]]
17+
; CHECK-CA510: [[VECTOR_MEMCHECK]]:
18+
; CHECK-CA510-NEXT: [[TMP0:%.*]] = sub i64 [[DST1]], [[A2]]
19+
; CHECK-CA510-NEXT: [[DIFF_CHECK:%.*]] = icmp ult i64 [[TMP0]], 32
20+
; CHECK-CA510-NEXT: [[TMP1:%.*]] = sub i64 [[DST1]], [[B3]]
21+
; CHECK-CA510-NEXT: [[DIFF_CHECK4:%.*]] = icmp ult i64 [[TMP1]], 32
22+
; CHECK-CA510-NEXT: [[CONFLICT_RDX:%.*]] = or i1 [[DIFF_CHECK]], [[DIFF_CHECK4]]
23+
; CHECK-CA510-NEXT: br i1 [[CONFLICT_RDX]], label %[[SCALAR_PH]], label %[[VECTOR_PH:.*]]
24+
; CHECK-CA510: [[VECTOR_PH]]:
25+
; CHECK-CA510-NEXT: [[N_MOD_VF:%.*]] = urem i64 [[N]], 8
26+
; CHECK-CA510-NEXT: [[N_VEC:%.*]] = sub i64 [[N]], [[N_MOD_VF]]
27+
; CHECK-CA510-NEXT: br label %[[VECTOR_BODY:.*]]
28+
; CHECK-CA510: [[VECTOR_BODY]]:
29+
; CHECK-CA510-NEXT: [[INDEX:%.*]] = phi i64 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
30+
; CHECK-CA510-NEXT: [[TMP2:%.*]] = add i64 [[INDEX]], 0
31+
; CHECK-CA510-NEXT: [[TMP3:%.*]] = getelementptr inbounds nuw float, ptr [[A]], i64 [[TMP2]]
32+
; CHECK-CA510-NEXT: [[TMP4:%.*]] = getelementptr inbounds nuw float, ptr [[TMP3]], i32 0
33+
; CHECK-CA510-NEXT: [[TMP5:%.*]] = getelementptr inbounds nuw float, ptr [[TMP3]], i32 4
34+
; CHECK-CA510-NEXT: [[WIDE_LOAD:%.*]] = load <4 x float>, ptr [[TMP4]], align 4
35+
; CHECK-CA510-NEXT: [[WIDE_LOAD5:%.*]] = load <4 x float>, ptr [[TMP5]], align 4
36+
; CHECK-CA510-NEXT: [[TMP6:%.*]] = getelementptr inbounds nuw float, ptr [[B]], i64 [[TMP2]]
37+
; CHECK-CA510-NEXT: [[TMP7:%.*]] = getelementptr inbounds nuw float, ptr [[TMP6]], i32 0
38+
; CHECK-CA510-NEXT: [[TMP8:%.*]] = getelementptr inbounds nuw float, ptr [[TMP6]], i32 4
39+
; CHECK-CA510-NEXT: [[WIDE_LOAD6:%.*]] = load <4 x float>, ptr [[TMP7]], align 4
40+
; CHECK-CA510-NEXT: [[WIDE_LOAD7:%.*]] = load <4 x float>, ptr [[TMP8]], align 4
41+
; CHECK-CA510-NEXT: [[TMP9:%.*]] = fadd fast <4 x float> [[WIDE_LOAD6]], [[WIDE_LOAD]]
42+
; CHECK-CA510-NEXT: [[TMP10:%.*]] = fadd fast <4 x float> [[WIDE_LOAD7]], [[WIDE_LOAD5]]
43+
; CHECK-CA510-NEXT: [[TMP11:%.*]] = getelementptr inbounds nuw float, ptr [[DST]], i64 [[TMP2]]
44+
; CHECK-CA510-NEXT: [[TMP12:%.*]] = getelementptr inbounds nuw float, ptr [[TMP11]], i32 0
45+
; CHECK-CA510-NEXT: [[TMP13:%.*]] = getelementptr inbounds nuw float, ptr [[TMP11]], i32 4
46+
; CHECK-CA510-NEXT: store <4 x float> [[TMP9]], ptr [[TMP12]], align 4
47+
; CHECK-CA510-NEXT: store <4 x float> [[TMP10]], ptr [[TMP13]], align 4
48+
; CHECK-CA510-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 8
49+
; CHECK-CA510-NEXT: [[TMP14:%.*]] = icmp eq i64 [[INDEX_NEXT]], [[N_VEC]]
50+
; CHECK-CA510-NEXT: br i1 [[TMP14]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
51+
; CHECK-CA510: [[MIDDLE_BLOCK]]:
52+
; CHECK-CA510-NEXT: [[CMP_N:%.*]] = icmp eq i64 [[N]], [[N_VEC]]
53+
; CHECK-CA510-NEXT: br i1 [[CMP_N]], label %[[FOR_COND_CLEANUP_LOOPEXIT:.*]], label %[[SCALAR_PH]]
54+
; CHECK-CA510: [[SCALAR_PH]]:
55+
; CHECK-CA510-NEXT: [[BC_RESUME_VAL:%.*]] = phi i64 [ [[N_VEC]], %[[MIDDLE_BLOCK]] ], [ 0, %[[FOR_BODY_PREHEADER]] ], [ 0, %[[VECTOR_MEMCHECK]] ]
56+
; CHECK-CA510-NEXT: br label %[[FOR_BODY:.*]]
57+
; CHECK-CA510: [[FOR_BODY]]:
58+
; CHECK-CA510-NEXT: [[INDVARS_IV:%.*]] = phi i64 [ [[INDVARS_IV_NEXT:%.*]], %[[FOR_BODY]] ], [ [[BC_RESUME_VAL]], %[[SCALAR_PH]] ]
59+
; CHECK-CA510-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds nuw float, ptr [[A]], i64 [[INDVARS_IV]]
60+
; CHECK-CA510-NEXT: [[TMP15:%.*]] = load float, ptr [[ARRAYIDX]], align 4
61+
; CHECK-CA510-NEXT: [[ARRAYIDX2:%.*]] = getelementptr inbounds nuw float, ptr [[B]], i64 [[INDVARS_IV]]
62+
; CHECK-CA510-NEXT: [[TMP16:%.*]] = load float, ptr [[ARRAYIDX2]], align 4
63+
; CHECK-CA510-NEXT: [[ADD:%.*]] = fadd fast float [[TMP16]], [[TMP15]]
64+
; CHECK-CA510-NEXT: [[ARRAYIDX4:%.*]] = getelementptr inbounds nuw float, ptr [[DST]], i64 [[INDVARS_IV]]
65+
; CHECK-CA510-NEXT: store float [[ADD]], ptr [[ARRAYIDX4]], align 4
66+
; CHECK-CA510-NEXT: [[INDVARS_IV_NEXT]] = add nuw nsw i64 [[INDVARS_IV]], 1
67+
; CHECK-CA510-NEXT: [[EXITCOND_NOT:%.*]] = icmp eq i64 [[INDVARS_IV_NEXT]], [[N]]
68+
; CHECK-CA510-NEXT: br i1 [[EXITCOND_NOT]], label %[[FOR_COND_CLEANUP_LOOPEXIT]], label %[[FOR_BODY]], !llvm.loop [[LOOP3:![0-9]+]]
69+
; CHECK-CA510: [[FOR_COND_CLEANUP_LOOPEXIT]]:
70+
; CHECK-CA510-NEXT: br label %[[FOR_COND_CLEANUP]]
71+
; CHECK-CA510: [[FOR_COND_CLEANUP]]:
72+
; CHECK-CA510-NEXT: ret void
73+
;
74+
; CHECK-CA520-LABEL: define void @sve_add(
75+
; CHECK-CA520-SAME: ptr [[DST:%.*]], ptr [[A:%.*]], ptr [[B:%.*]], i64 [[N:%.*]]) #[[ATTR0:[0-9]+]] {
76+
; CHECK-CA520-NEXT: [[ENTRY:.*:]]
77+
; CHECK-CA520-NEXT: [[B3:%.*]] = ptrtoint ptr [[B]] to i64
78+
; CHECK-CA520-NEXT: [[A2:%.*]] = ptrtoint ptr [[A]] to i64
79+
; CHECK-CA520-NEXT: [[DST1:%.*]] = ptrtoint ptr [[DST]] to i64
80+
; CHECK-CA520-NEXT: [[CMP9_NOT:%.*]] = icmp eq i64 [[N]], 0
81+
; CHECK-CA520-NEXT: br i1 [[CMP9_NOT]], label %[[FOR_COND_CLEANUP:.*]], label %[[FOR_BODY_PREHEADER:.*]]
82+
; CHECK-CA520: [[FOR_BODY_PREHEADER]]:
83+
; CHECK-CA520-NEXT: [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[N]], 8
84+
; CHECK-CA520-NEXT: br i1 [[MIN_ITERS_CHECK]], label %[[SCALAR_PH:.*]], label %[[VECTOR_MEMCHECK:.*]]
85+
; CHECK-CA520: [[VECTOR_MEMCHECK]]:
86+
; CHECK-CA520-NEXT: [[TMP0:%.*]] = sub i64 [[DST1]], [[A2]]
87+
; CHECK-CA520-NEXT: [[DIFF_CHECK:%.*]] = icmp ult i64 [[TMP0]], 32
88+
; CHECK-CA520-NEXT: [[TMP1:%.*]] = sub i64 [[DST1]], [[B3]]
89+
; CHECK-CA520-NEXT: [[DIFF_CHECK4:%.*]] = icmp ult i64 [[TMP1]], 32
90+
; CHECK-CA520-NEXT: [[CONFLICT_RDX:%.*]] = or i1 [[DIFF_CHECK]], [[DIFF_CHECK4]]
91+
; CHECK-CA520-NEXT: br i1 [[CONFLICT_RDX]], label %[[SCALAR_PH]], label %[[VECTOR_PH:.*]]
92+
; CHECK-CA520: [[VECTOR_PH]]:
93+
; CHECK-CA520-NEXT: [[N_MOD_VF:%.*]] = urem i64 [[N]], 8
94+
; CHECK-CA520-NEXT: [[N_VEC:%.*]] = sub i64 [[N]], [[N_MOD_VF]]
95+
; CHECK-CA520-NEXT: br label %[[VECTOR_BODY:.*]]
96+
; CHECK-CA520: [[VECTOR_BODY]]:
97+
; CHECK-CA520-NEXT: [[INDEX:%.*]] = phi i64 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
98+
; CHECK-CA520-NEXT: [[TMP2:%.*]] = add i64 [[INDEX]], 0
99+
; CHECK-CA520-NEXT: [[TMP3:%.*]] = getelementptr inbounds nuw float, ptr [[A]], i64 [[TMP2]]
100+
; CHECK-CA520-NEXT: [[TMP4:%.*]] = getelementptr inbounds nuw float, ptr [[TMP3]], i32 0
101+
; CHECK-CA520-NEXT: [[TMP5:%.*]] = getelementptr inbounds nuw float, ptr [[TMP3]], i32 4
102+
; CHECK-CA520-NEXT: [[WIDE_LOAD:%.*]] = load <4 x float>, ptr [[TMP4]], align 4
103+
; CHECK-CA520-NEXT: [[WIDE_LOAD5:%.*]] = load <4 x float>, ptr [[TMP5]], align 4
104+
; CHECK-CA520-NEXT: [[TMP6:%.*]] = getelementptr inbounds nuw float, ptr [[B]], i64 [[TMP2]]
105+
; CHECK-CA520-NEXT: [[TMP7:%.*]] = getelementptr inbounds nuw float, ptr [[TMP6]], i32 0
106+
; CHECK-CA520-NEXT: [[TMP8:%.*]] = getelementptr inbounds nuw float, ptr [[TMP6]], i32 4
107+
; CHECK-CA520-NEXT: [[WIDE_LOAD6:%.*]] = load <4 x float>, ptr [[TMP7]], align 4
108+
; CHECK-CA520-NEXT: [[WIDE_LOAD7:%.*]] = load <4 x float>, ptr [[TMP8]], align 4
109+
; CHECK-CA520-NEXT: [[TMP9:%.*]] = fadd fast <4 x float> [[WIDE_LOAD6]], [[WIDE_LOAD]]
110+
; CHECK-CA520-NEXT: [[TMP10:%.*]] = fadd fast <4 x float> [[WIDE_LOAD7]], [[WIDE_LOAD5]]
111+
; CHECK-CA520-NEXT: [[TMP11:%.*]] = getelementptr inbounds nuw float, ptr [[DST]], i64 [[TMP2]]
112+
; CHECK-CA520-NEXT: [[TMP12:%.*]] = getelementptr inbounds nuw float, ptr [[TMP11]], i32 0
113+
; CHECK-CA520-NEXT: [[TMP13:%.*]] = getelementptr inbounds nuw float, ptr [[TMP11]], i32 4
114+
; CHECK-CA520-NEXT: store <4 x float> [[TMP9]], ptr [[TMP12]], align 4
115+
; CHECK-CA520-NEXT: store <4 x float> [[TMP10]], ptr [[TMP13]], align 4
116+
; CHECK-CA520-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 8
117+
; CHECK-CA520-NEXT: [[TMP14:%.*]] = icmp eq i64 [[INDEX_NEXT]], [[N_VEC]]
118+
; CHECK-CA520-NEXT: br i1 [[TMP14]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
119+
; CHECK-CA520: [[MIDDLE_BLOCK]]:
120+
; CHECK-CA520-NEXT: [[CMP_N:%.*]] = icmp eq i64 [[N]], [[N_VEC]]
121+
; CHECK-CA520-NEXT: br i1 [[CMP_N]], label %[[FOR_COND_CLEANUP_LOOPEXIT:.*]], label %[[SCALAR_PH]]
122+
; CHECK-CA520: [[SCALAR_PH]]:
123+
; CHECK-CA520-NEXT: [[BC_RESUME_VAL:%.*]] = phi i64 [ [[N_VEC]], %[[MIDDLE_BLOCK]] ], [ 0, %[[FOR_BODY_PREHEADER]] ], [ 0, %[[VECTOR_MEMCHECK]] ]
124+
; CHECK-CA520-NEXT: br label %[[FOR_BODY:.*]]
125+
; CHECK-CA520: [[FOR_BODY]]:
126+
; CHECK-CA520-NEXT: [[INDVARS_IV:%.*]] = phi i64 [ [[INDVARS_IV_NEXT:%.*]], %[[FOR_BODY]] ], [ [[BC_RESUME_VAL]], %[[SCALAR_PH]] ]
127+
; CHECK-CA520-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds nuw float, ptr [[A]], i64 [[INDVARS_IV]]
128+
; CHECK-CA520-NEXT: [[TMP15:%.*]] = load float, ptr [[ARRAYIDX]], align 4
129+
; CHECK-CA520-NEXT: [[ARRAYIDX2:%.*]] = getelementptr inbounds nuw float, ptr [[B]], i64 [[INDVARS_IV]]
130+
; CHECK-CA520-NEXT: [[TMP16:%.*]] = load float, ptr [[ARRAYIDX2]], align 4
131+
; CHECK-CA520-NEXT: [[ADD:%.*]] = fadd fast float [[TMP16]], [[TMP15]]
132+
; CHECK-CA520-NEXT: [[ARRAYIDX4:%.*]] = getelementptr inbounds nuw float, ptr [[DST]], i64 [[INDVARS_IV]]
133+
; CHECK-CA520-NEXT: store float [[ADD]], ptr [[ARRAYIDX4]], align 4
134+
; CHECK-CA520-NEXT: [[INDVARS_IV_NEXT]] = add nuw nsw i64 [[INDVARS_IV]], 1
135+
; CHECK-CA520-NEXT: [[EXITCOND_NOT:%.*]] = icmp eq i64 [[INDVARS_IV_NEXT]], [[N]]
136+
; CHECK-CA520-NEXT: br i1 [[EXITCOND_NOT]], label %[[FOR_COND_CLEANUP_LOOPEXIT]], label %[[FOR_BODY]], !llvm.loop [[LOOP3:![0-9]+]]
137+
; CHECK-CA520: [[FOR_COND_CLEANUP_LOOPEXIT]]:
138+
; CHECK-CA520-NEXT: br label %[[FOR_COND_CLEANUP]]
139+
; CHECK-CA520: [[FOR_COND_CLEANUP]]:
140+
; CHECK-CA520-NEXT: ret void
141+
;
142+
entry:
143+
%cmp9.not = icmp eq i64 %n, 0
144+
br i1 %cmp9.not, label %for.cond.cleanup, label %for.body
145+
for.body: ; preds = %for.body.preheader, %for.body
146+
%indvars.iv = phi i64 [ 0, %entry], [ %indvars.iv.next, %for.body ]
147+
%arrayidx = getelementptr inbounds nuw float, ptr %a, i64 %indvars.iv
148+
%0 = load float, ptr %arrayidx, align 4
149+
%arrayidx2 = getelementptr inbounds nuw float, ptr %b, i64 %indvars.iv
150+
%1 = load float, ptr %arrayidx2, align 4
151+
%add = fadd fast float %1, %0
152+
%arrayidx4 = getelementptr inbounds nuw float, ptr %dst, i64 %indvars.iv
153+
store float %add, ptr %arrayidx4, align 4
154+
%indvars.iv.next = add nuw nsw i64 %indvars.iv, 1
155+
%exitcond.not = icmp eq i64 %indvars.iv.next, %n
156+
br i1 %exitcond.not, label %for.cond.cleanup, label %for.body
157+
for.cond.cleanup: ; preds = %for.cond.cleanup.loopexit, %entry
158+
ret void
159+
}
160+
;.
161+
; CHECK-CA510: [[LOOP0]] = distinct !{[[LOOP0]], [[META1:![0-9]+]], [[META2:![0-9]+]]}
162+
; CHECK-CA510: [[META1]] = !{!"llvm.loop.isvectorized", i32 1}
163+
; CHECK-CA510: [[META2]] = !{!"llvm.loop.unroll.runtime.disable"}
164+
; CHECK-CA510: [[LOOP3]] = distinct !{[[LOOP3]], [[META1]]}
165+
;.
166+
; CHECK-CA520: [[LOOP0]] = distinct !{[[LOOP0]], [[META1:![0-9]+]], [[META2:![0-9]+]]}
167+
; CHECK-CA520: [[META1]] = !{!"llvm.loop.isvectorized", i32 1}
168+
; CHECK-CA520: [[META2]] = !{!"llvm.loop.unroll.runtime.disable"}
169+
; CHECK-CA520: [[LOOP3]] = distinct !{[[LOOP3]], [[META1]]}
170+
;.

0 commit comments

Comments
 (0)