Skip to content

Commit a2b51aa

Browse files
committed
Address more comments
1 parent 8d88049 commit a2b51aa

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

clang/include/clang/Interpreter/Interpreter.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ class Interpreter {
9595
// An optional parser for CUDA offloading
9696
std::unique_ptr<IncrementalParser> DeviceParser;
9797

98-
/// List containing every information about every incrementally parsed piece
99-
/// of code.
98+
/// List containing information about each incrementally parsed piece of code.
10099
std::list<PartialTranslationUnit> PTUs;
101100

102101
unsigned InitPTUSize = 0;

clang/lib/Interpreter/DeviceOffload.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class IncrementalCUDADeviceParser : public IncrementalParser {
4949
llvm::SmallString<1024> PTXCode;
5050
llvm::SmallVector<char, 1024> FatbinContent;
5151
llvm::IntrusiveRefCntPtr<llvm::vfs::InMemoryFileSystem> VFS;
52-
CodeGenOptions &CodeGenOpts; // intentionally a reference.
52+
CodeGenOptions &CodeGenOpts; // Intentionally a reference.
5353
const TargetOptions &TargetOpts;
5454
};
5555

clang/lib/Interpreter/Interpreter.cpp

-7
Original file line numberDiff line numberDiff line change
@@ -302,22 +302,15 @@ class IncrementalAction : public WrapperFrontendAction {
302302
CI.getFrontendOpts().ProgramAction);
303303
return Act;
304304
case frontend::ASTDump:
305-
[[fallthrough]];
306305
case frontend::ASTPrint:
307-
[[fallthrough]];
308306
case frontend::ParseSyntaxOnly:
309307
Act = CreateFrontendAction(CI);
310308
break;
311309
case frontend::PluginAction:
312-
[[fallthrough]];
313310
case frontend::EmitAssembly:
314-
[[fallthrough]];
315311
case frontend::EmitBC:
316-
[[fallthrough]];
317312
case frontend::EmitObj:
318-
[[fallthrough]];
319313
case frontend::PrintPreprocessedInput:
320-
[[fallthrough]];
321314
case frontend::EmitLLVMOnly:
322315
Act.reset(new EmitLLVMOnlyAction(&LLVMCtx));
323316
break;

0 commit comments

Comments
 (0)