Skip to content

Commit a85d3a5

Browse files
authored
[lldb] Turn off AdbClientTest on windows to fix build breakage (#160771)
#159676 was recently landed. After it was landed, additional tests were ran, where I saw an assertion error on windows only. I am not able to test on windows, and the test is a new test to mock an adb server. The mock server fails to start on windows, so I am disabling to fix the breakage on main. This is not an issue with the main code, only a test issue. Relevant error output: ``` Step 8 (test-check-lldb-unit) failure: Test just built components: check-lldb-unit completed (failure) ******************** TEST 'lldb-unit :: Platform/Android/./AdbClientTests.exe/7/20' FAILED ******************** Script(shard): -- GTEST_OUTPUT=json:C:\buildbot\as-builder-10\lldb-x86-64\build\tools\lldb\unittests\Platform\Android\.\AdbClientTests.exe-lldb-unit-30696-7-20.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=20 GTEST_SHARD_INDEX=7 C:\buildbot\as-builder-10\lldb-x86-64\build\tools\lldb\unittests\Platform\Android\.\AdbClientTests.exe -- Note: This is test shard 8 of 20. [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from AdbClientTest [ RUN ] AdbClientTest.RealTcpConnection Assertion failed: error.Fail(), file C:\buildbot\as-builder-10\lldb-x86-64\llvm-project\lldb\source\Host\common\TCPSocket.cpp, line 254 ```
1 parent 1e302e9 commit a85d3a5

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lldb/unittests/Platform/Android/AdbClientTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ static uint16_t FindUnusedPort() {
108108
return port;
109109
}
110110

111+
#ifndef _WIN32
112+
// This test is disabled on Windows due to platform-specific socket behavior
113+
// that causes assertion failures in TCPSocket::Listen()
111114
TEST_F(AdbClientTest, RealTcpConnection) {
112115
uint16_t unused_port = FindUnusedPort();
113116
ASSERT_NE(unused_port, 0) << "Failed to find an unused port";
@@ -137,3 +140,4 @@ TEST_F(AdbClientTest, RealTcpConnection) {
137140
<< "Connection should succeed when server is listening on port "
138141
<< unused_port;
139142
}
143+
#endif // _WIN32

0 commit comments

Comments
 (0)