Skip to content

Commit b2418f8

Browse files
author
Peiming Liu
committed
address comments
1 parent d6093ea commit b2418f8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1256,7 +1256,7 @@ bool ConcatenateOp::needExtraSort() {
12561256
bool allSameOrdered = llvm::all_of(getInputs(), [dstStt](Value op) {
12571257
return getSparseTensorType(op).hasSameDimToLvl(dstStt);
12581258
});
1259-
// TODO: When conDim != 0, as long as conDim corresponding to the first level
1259+
// TODO: When conDim != 0, as long as conDim corresponding to the first level
12601260
// in all input/output buffers, and all input/output buffers have the same
12611261
// dimToLvl, the tmp COO buffer is still unnecessary (e.g, concatenate
12621262
// CSC matrices along column).

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,7 @@ struct ConcatenateRewriter : public OpRewritePattern<ConcatenateOp> {
905905

906906
ForeachOp foreachOp;
907907
for (Value input : op.getInputs()) {
908-
// Build a for op for each input tensor to append new values into the
908+
// Builds a for op for each input tensor to append new values into the
909909
// output tensor.
910910
foreachOp = rewriter.create<ForeachOp>(
911911
loc, input, iterArg ? ValueRange{iterArg} : ValueRange{},
@@ -914,7 +914,7 @@ struct ConcatenateRewriter : public OpRewritePattern<ConcatenateOp> {
914914
SmallVector<Value> dstLcvs(dstTp.getLvlRank());
915915
for (Dimension d = 0; d < dimRank; d++) {
916916
Value crd = dcvs[d];
917-
// Transform coordinates for the concatenating dim.
917+
// Transforms coordinates for the concatenating dim.
918918
if (d == conDim)
919919
crd = builder.create<arith::AddIOp>(loc, crd, offset);
920920
// FIXME: `toStoredDim` is deprecated

0 commit comments

Comments
 (0)