[AST] Avoid repeated hash lookups (NFC) (#109603)

kazutakahirata · web-flow · commit d6a6e25c5158 · 2024-09-23T06:45:59.000-07:00
diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp
@@ -12587,8 +12587,7 @@ void ASTContext::forEachMultiversionedFunctionVersion(
        FD->getDeclContext()->getRedeclContext()->lookup(FD->getDeclName())) {
     FunctionDecl *CurFD = CurDecl->getAsFunction()->getMostRecentDecl();
     if (CurFD && hasSameType(CurFD->getType(), FD->getType()) &&
-        !SeenDecls.contains(CurFD)) {
-      SeenDecls.insert(CurFD);
+        SeenDecls.insert(CurFD).second) {
       Pred(CurFD);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -12587,8 +12587,7 @@ void ASTContext::forEachMultiversionedFunctionVersion(`
`12587`	`12587`	`FD->getDeclContext()->getRedeclContext()->lookup(FD->getDeclName())) {`
`12588`	`12588`	`FunctionDecl *CurFD = CurDecl->getAsFunction()->getMostRecentDecl();`
`12589`	`12589`	`if (CurFD && hasSameType(CurFD->getType(), FD->getType()) &&`
`12590`		`- !SeenDecls.contains(CurFD)) {`
`12591`		`- SeenDecls.insert(CurFD);`
	`12590`	`+ SeenDecls.insert(CurFD).second) {`
`12592`	`12591`	`Pred(CurFD);`
`12593`	`12592`	`}`
`12594`	`12593`	`}`