Skip to content

Commit dc27d21

Browse files
committed
[mlir][nvvm] Use NVVMMemorySpace instead of hardcoded values (nfc)
1 parent 69660cc commit dc27d21

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,8 @@ inferMMATypeFromMNK(NVVM::MMATypes type, NVVM::MMAFrag frag, int m, int n,
624624
LogicalResult NVVM::WMMALoadOp::verify() {
625625
unsigned addressSpace =
626626
llvm::cast<LLVM::LLVMPointerType>(getPtr().getType()).getAddressSpace();
627-
if (addressSpace != 0 && addressSpace != 1 && addressSpace != 3)
627+
if (addressSpace != 0 && addressSpace != NVVM::kGlobalMemorySpace &&
628+
addressSpace != NVVM::kSharedMemorySpace)
628629
return emitOpError("expected source pointer in memory "
629630
"space 0, 1, 3");
630631

@@ -644,7 +645,8 @@ LogicalResult NVVM::WMMALoadOp::verify() {
644645
LogicalResult NVVM::WMMAStoreOp::verify() {
645646
unsigned addressSpace =
646647
llvm::cast<LLVM::LLVMPointerType>(getPtr().getType()).getAddressSpace();
647-
if (addressSpace != 0 && addressSpace != 1 && addressSpace != 3)
648+
if (addressSpace != 0 && addressSpace != NVVM::kGlobalMemorySpace &&
649+
addressSpace != NVVM::kSharedMemorySpace)
648650
return emitOpError("expected operands to be a source pointer in memory "
649651
"space 0, 1, 3");
650652

@@ -696,7 +698,7 @@ LogicalResult NVVM::WMMAMmaOp::verify() {
696698
LogicalResult NVVM::LdMatrixOp::verify() {
697699
unsigned addressSpace =
698700
llvm::cast<LLVM::LLVMPointerType>(getPtr().getType()).getAddressSpace();
699-
if (addressSpace != 3)
701+
if (addressSpace != NVVM::kSharedMemorySpace)
700702
return emitOpError("expected source pointer in memory space 3");
701703

702704
if (getNum() != 1 && getNum() != 2 && getNum() != 4)

0 commit comments

Comments
 (0)