Skip to content

Commit f2987f2

Browse files
authored
[X86][AVX10] Make warning message more informative, NFCI (#134528)
1 parent 146ad71 commit f2987f2

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Diff for: clang/lib/Driver/ToolChains/Arch/X86.cpp

+6-2
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,9 @@ void x86::getX86TargetFeatures(const Driver &D, const llvm::Triple &Triple,
252252
D.Diag(diag::warn_drv_deprecated_arg) << Name << 1 << Name.drop_back(4);
253253
else if (Width == "256")
254254
D.Diag(diag::warn_drv_deprecated_custom)
255-
<< Name << "because AVX10/256 is not supported and will be removed";
255+
<< Name
256+
<< "no alternative argument provided because "
257+
"AVX10/256 is not supported and will be removed";
256258
else
257259
assert((Width == "256" || Width == "512") && "Invalid vector length.");
258260
Features.push_back(Args.MakeArgString((IsNegative ? "-" : "+") + Name));
@@ -286,7 +288,9 @@ void x86::getX86TargetFeatures(const Driver &D, const llvm::Triple &Triple,
286288
if (A->getOption().matches(options::OPT_mevex512) ||
287289
A->getOption().matches(options::OPT_mno_evex512))
288290
D.Diag(diag::warn_drv_deprecated_custom)
289-
<< Name << "because AVX10/256 is not supported and will be removed";
291+
<< Name
292+
<< "no alternative argument provided because "
293+
"AVX10/256 is not supported and will be removed";
290294

291295
if (A->getOption().matches(options::OPT_mapx_features_EQ) ||
292296
A->getOption().matches(options::OPT_mno_apx_features_EQ)) {

Diff for: clang/test/Driver/x86-target-features.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -411,8 +411,8 @@
411411
// RUN: %clang --target=i386 -mavx10.2-512 %s -### -o %t.o 2>&1 | FileCheck -check-prefixes=AVX10_2_512,WARN-AVX10-512 %s
412412
// RUN: %clang --target=i386 -mavx10.2-256 -mavx10.1-512 %s -### -o %t.o 2>&1 | FileCheck -check-prefixes=AVX10_2_256,AVX10_1_512 %s
413413
// RUN: %clang --target=i386 -mavx10.2-512 -mavx10.1-256 %s -### -o %t.o 2>&1 | FileCheck -check-prefixes=AVX10_2_512,AVX10_1_256 %s
414-
// WARN-EVEX512: warning: argument '{{.*}}evex512' is deprecated, because AVX10/256 is not supported and will be removed [-Wdeprecated]
415-
// WARN-AVX10-256: warning: argument 'avx10.{{.*}}-256' is deprecated, because AVX10/256 is not supported and will be removed [-Wdeprecated]
414+
// WARN-EVEX512: warning: argument '{{.*}}evex512' is deprecated, no alternative argument provided because AVX10/256 is not supported and will be removed [-Wdeprecated]
415+
// WARN-AVX10-256: warning: argument 'avx10.{{.*}}-256' is deprecated, no alternative argument provided because AVX10/256 is not supported and will be removed [-Wdeprecated]
416416
// WARN-AVX10-512: warning: argument 'avx10.{{.*}}-512' is deprecated, use 'avx10.{{.*}}' instead [-Wdeprecated]
417417
// EVEX512: "-target-feature" "+evex512"
418418
// NO-EVEX512: "-target-feature" "-evex512"

0 commit comments

Comments
 (0)