[BOLT] Add assert wehn calling insertBTI on empty BBs

BOLT may generate empty BBs, e.g. around function splitting, to hold
temporary labels. If they are the target of a new indirect branch, the
BTI should be inserted into the first "real" BasicBlock.

Author: bgergely0

bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp

@@ -2869,6 +2869,10 @@ class AArch64MCPlusBuilder : public MCPlusBuilder {
 
   void insertBTI(BinaryBasicBlock &BB, MCInst &Call) const override {
     auto II = BB.getFirstNonPseudo();
+    assert(II != BB.end() &&
+           "insertBTI should only be called on non-empty BasicBlocks");
+    // Make sure there is no crash in non-assertion builds when calling on empty
+    // BBs.
     if (II != BB.end()) {
       if (isBTIVariantCoveringCall(Call, *II))
         return;

bolt/unittests/Core/MCPlusBuilder.cpp

@@ -198,6 +198,20 @@ TEST_P(MCPlusBuilderTester, AArch64_BTI) {
   ASSERT_TRUE(BC->MIB->isImplicitBTIC(*II));
 }
 
+TEST_P(MCPlusBuilderTester, AArch64_insertBTI_empty) {
+  if (GetParam() != Triple::aarch64)
+    GTEST_SKIP();
+  BinaryFunction *BF = BC->createInjectedBinaryFunction("BF", true);
+  std::unique_ptr<BinaryBasicBlock> BB = BF->createBasicBlock();
+  MCInst CallInst = MCInstBuilder(AArch64::BR).addReg(AArch64::X16);
+#ifndef NDEBUG
+  ASSERT_DEATH(BC->MIB->insertBTI(*BB, CallInst),
+               "insertBTI should only be called on non-empty BasicBlocks");
+#else
+  BC->MIB->insertBTI(*BB, CallInst);
+  ASSERT(BB->size() == 0);
+#endif
+}
 TEST_P(MCPlusBuilderTester, AArch64_insertBTI_0) {
   if (GetParam() != Triple::aarch64)
     GTEST_SKIP();