Skip to content

xacquire/xrelease parsed improperly #30428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Keno opened this issue Nov 21, 2016 · 1 comment
Closed

xacquire/xrelease parsed improperly #30428

Keno opened this issue Nov 21, 2016 · 1 comment
Labels
backend:X86 bugzilla Issues migrated from bugzilla

Comments

@Keno
Copy link
Member

Keno commented Nov 21, 2016

Bugzilla Link 31080
Version 3.9
OS All
Blocks #11360
CC @topperc

Extended Description

$ llvm-mc
xrelease lock subq $1,4(%rip)
	.text
<stdin>:1:15: error: unexpected token in argument list
xrelease lock subq $1,4(%rip)
              ^

gcc accepts this fine. For now treating is as a separate instruction with ; works,
but seems a little wrong.

xrelease; lock subq $1,4(%rip)
@llvmbot
Copy link
Member

llvmbot commented Jan 19, 2018

Hi,
I checked this issue with the current trunk: everythig works perfectly:

atischenko@ip-172-31-21-62:~/workspaces/trunk/build/bin$ cat test.s
xrelease lock subq $1,4(%rip);

atischenko@ip-172-31-21-62:~/workspaces/trunk/build/bin$ llvm-mc -show-encoding test.s
.text
xrelease # encoding: [0xf3]
lock subq $1, 4(%rip) # encoding: [0xf0,0x48,0x83,0x2d,0x03,0x00,0x00,0x00,0x01]

atischenko@ip-172-31-21-62:~/workspaces/trunk/build/bin$ cat test.txt
0xf3, 0xf0,0x48,0x83,0x2d,0x03,0x00,0x00,0x00,0x01

atischenko@ip-172-31-21-62:~/workspaces/trunk/build/bin$ llvm-mc -disassemble test.txt
.text
xrelease
lock
subq $1, 3(%rip)

As you see both assembler and dissassembler produce correct results.
It seems we should close the bug, right?

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@Keno Keno closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:X86 bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants