clang: python bindings, test_code_complete_availability fails

[llvmbot]

Bugzilla Link	38417
Resolution	FIXED
Resolved on	Oct 22, 2018 22:19
Version	7.0
OS	Linux
Blocks	#38454
Attachments	dev-python:clang-python-7.0.9999:20180802-074944.log
Reporter	LLVM Bugzilla Contributor
CC	@zmodem,@tstellar
Fixed by commit(s)	r342897 r345000

Extended Description

This is a regression since 6.0*.

======================================================================
FAIL: test_code_complete_availability (tests.cindex.test_code_completion.TestCodeCompletion)

Traceback (most recent call last):
File "/var/tmp/portage/dev-python/clang-python-7.0.9999/work/clang-python-7.0.9999/bindings/python/tests/cindex/test_code_completion.py", line 70, in test_code_complete_availability
self.check_completion_results(cr, expected)
File "/var/tmp/portage/dev-python/clang-python-7.0.9999/work/clang-python-7.0.9999/bindings/python/tests/cindex/test_code_completion.py", line 14, in check_completion_results
self.assertIn(c, completions)
AssertionError: "{'const', TypedText} || Priority: 40 || Availability: Available || Brief comment: None" not found in ["{'P', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'Q', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'namespace', TypedText} | {' ', HorizontalSpace} | {'name', Placeholder} | {'=', Equal} | {'namespace', Placeholder} || Priority: 40 || Availability: Available || Brief comment: None", "{'using', TypedText} | {' ', HorizontalSpace} | {'namespace', Text} | {' ', HorizontalSpace} | {'identifier', Placeholder} || Priority: 40 || Availability: Available || Brief comment: None", "{'asm', TypedText} | {'(', LeftParen} | {'string-literal', Placeholder} | {')', RightParen} || Priority: 40 || Availability: Available || Brief comment: None", "{'typedef', TypedText} | {' ', HorizontalSpace} | {'type', Placeholder} | {' ', HorizontalSpace} | {'name', Placeholder} || Priority: 40 || Availability: Available || Brief comment: None", "{'using', TypedText} | {' ', HorizontalSpace} | {'qualifier', Placeholder} | {'::', Text} | {'name', Placeholder} || Priority: 40 || Availability: Available || Brief comment: None", "{'extern', TypedText} || Priority: 40 || Availability: Available || Brief comment: None", "{'static', TypedText} || Priority: 40 || Availability: Available || Brief comment: None", "{'inline', TypedText} || Priority: 40 || Availability: Available || Brief comment: None", "{'short', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'long', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'signed', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'unsigned', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'void', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'char', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'int', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'float', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'double', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'enum', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'struct', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'union', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'const', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'volatile', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'bool', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'class', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'wchar_t', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'typename', TypedText} | {' ', HorizontalSpace} | {'qualifier', Placeholder} | {'::', Text} | {'name', Placeholder} || Priority: 40 || Availability: Available || Brief comment: None", "{'_Nonnull', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'_Null_unspecified', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'_Nullable', TypedText} || Priority: 50 || Availability: Available || Brief comment: None", "{'operator', TypedText} || Priority: 40 || Availability: Available || Brief comment: None"]

---

Ran 120 tests in 1.141s

FAILED (failures=1)

[zmodem]

Any idea why this isn't failing on other platforms? Who owns this functionality?

[llvmbot]

Any idea why this isn't failing on other platforms? Who owns this
functionality?

The most likely reason is that nobody else is running those tests. I'm not aware of who the owner of Python bindings is. The previous time the completion tests were broken the patch was merged by ilya-biryukov [1] (who was the one making the original change breaking the tests).

I see that I've failed to link the new patch [2].

[1] https://reviews.llvm.org/D39838
[2] https://reviews.llvm.org/D50171

[zmodem]

Sorry, there doesn't seem to be enough interest in getting this fixed for the release. I won't block on it.

[llvmbot]

Could we backport it to 7.0.1 now?

[tstellar]

Is the request here to merge r342897?

[llvmbot]

Is the request here to merge r342897?

Yes, please.

[tstellar]

Merged: r345000

[tstellar]

mentioned in issue #38454