Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit third operand for the rdhwr instruction on MIPS64 < R6 #38209

Closed
atanasyan opened this issue Sep 7, 2018 · 7 comments
Closed

Emit third operand for the rdhwr instruction on MIPS64 < R6 #38209

atanasyan opened this issue Sep 7, 2018 · 7 comments
Assignees
Labels
backend:MIPS bugzilla Issues migrated from bugzilla

Comments

@atanasyan
Copy link
Collaborator

Bugzilla Link 38861
Resolution FIXED
Resolved on Nov 15, 2018 21:23
Version trunk
OS All
Blocks #38454
CC @jrtc27,@sylvestre,@tstellar
Fixed by commit(s) r341919 r346739

Extended Description

MIPS ISAs before "Revision 6" do not support third operand for the rdhwr instruction. But LLVM generates three-operands version of the instruction on any MIPS64 ISAs. This is regression caused by r335162.

% cat test.ll
declare i8* @​llvm.thread.pointer() nounwind readnone

define i8* @​thread_pointer() {
%1 = tail call i8* @​llvm.thread.pointer()
ret i8* %1
}

% llc -march=mips64 < test.ll
...
rdhwr $3, $29, 0

% llc -march=mips < test.ll
...
rdhwr $3, $29

@atanasyan
Copy link
Collaborator Author

assigned to @atanasyan

@atanasyan
Copy link
Collaborator Author

Fixed at r341919.
https://reviews.llvm.org/rL341919

@jrtc27
Copy link
Collaborator

jrtc27 commented Nov 3, 2018

This affects the release_70 branch; could it please be cherry-picked?

@sylvestre
Copy link
Collaborator

yeah, we should back port it. I have been affected by this in the debian packaging.

@atanasyan
Copy link
Collaborator Author

Sure. I'm going to send request on backporting this and some other MIPS-related commits soon.

@tstellar
Copy link
Collaborator

mentioned in issue #38454

@atanasyan
Copy link
Collaborator Author

mentioned in issue llvm/llvm-bugzilla-archive#39611

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:MIPS bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

4 participants