Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86][SSE] Merge rL343373 into 7.0.1 - Fixed issue with v2i64 variable shifts on 32-bit targets #38499

Closed
RKSimon opened this issue Oct 2, 2018 · 4 comments
Assignees
Labels
backend:X86 bugzilla Issues migrated from bugzilla

Comments

@RKSimon
Copy link
Collaborator

RKSimon commented Oct 2, 2018

Bugzilla Link 39151
Resolution FIXED
Resolved on Oct 19, 2018 12:57
Version trunk
OS Windows NT
Blocks #38454
CC @topperc,@zmodem,@tstellar
Fixed by commit(s) r343373 r344810

Extended Description

[X86][SSE] Fixed issue with v2i64 variable shifts on 32-bit targets

The shift amount might have peeked through a extract_subvector, altering the number of vector elements in the 'Amt' variable - so we were incorrectly calculating the ratio when peeking through bitcasts, resulting in incorrectly detecting splats.

@RKSimon
Copy link
Collaborator Author

RKSimon commented Oct 2, 2018

assigned to @topperc

@tstellar
Copy link
Collaborator

Hi Craig,

Is this OK to merge?

https://reviews.llvm.org/rL343373

@topperc
Copy link
Collaborator

topperc commented Oct 19, 2018

Yes, this is ok to merge.

@tstellar
Copy link
Collaborator

Merged: r344810

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:X86 bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

3 participants