7.0.1 backport: Assertion failed: (!m_first_die || m_first_die == m_die_array.front())…

[jankratochvil]

Bugzilla Link	39330
Resolution	FIXED
Resolved on	Nov 15, 2018 22:04
Version	7.0
OS	Linux
Blocks	#38454
CC	@labath,@tstellar
Fixed by commit(s)	r344605 r347030

Extended Description

Please backport:
Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front())…
https://reviews.llvm.org/rL344605

[jankratochvil]

assigned to @davidbolvansky

[tstellar]

Hi Jason,

Is this OK to merge?

[jankratochvil]

Hi Jason,
ping so that I am not accused of regressing even 7.0.1:
[lldb-dev] LLVM 7.0.1-rc1 release on Thursday
https://lists.llvm.org/pipermail/lldb-dev/2018-October/014326.html
Is this OK to merge? Thanks.

[jankratochvil]

Tom, if you are concerned about the trunk assertion adjustment couldn't me/you just remove the assertion? I introduced the assertion recently in https://reviews.llvm.org/D46810 myself anyway.

[jankratochvil]

Hello David,
I need your review/approval for the 3-line backport mentioned above,
thanks. Do you find the change safe enough for the 7.0.1 branch?

[davidbolvansky]

We backported this fix and all is OK.

I think you should merge it since the asserting code is too radical here.

[davidbolvansky]

Added Pavel since he knows a bit about this issue (btw, pavel, is “depth” issue related to this fix or is it a second independent bug?)

[tstellar]

Merged: r346873

[tstellar]

Merged: r347030