Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r345353 into the 7.0 branch : Teach the DominatorTree fallback to recalculation when applying updates to speedup JT (#37929 ) #38932

Closed
llvmbot opened this issue Nov 8, 2018 · 7 comments
Closed

Merge r345353 into the 7.0 branch : Teach the DominatorTree fallback to recalculation when applying updates to speedup JT (#37929 ) #38932

llvmbot opened this issue Nov 8, 2018 · 7 comments
Assignees
@kuhar
Labels
bugzilla Issues migrated from bugzilla

Comments

@llvmbot
Copy link
Member

llvmbot commented Nov 8, 2018

Bugzilla Link 39584
Resolution FIXED
Resolved on Nov 19, 2018 19:42
Version 7.0
OS All
Blocks #38454
Reporter LLVM Bugzilla Contributor
CC @tstellar
Fixed by commit(s) r345353 r347285

Extended Description

Is it OK to merge the following revision(s) to the 7.0 branch?
@llvmbot
Copy link
Member Author

llvmbot commented Nov 8, 2018

assigned to @kuhar

@llvmbot
Copy link
Member Author

llvmbot commented Nov 8, 2018

https://reviews.llvm.org/rL345353

@llvmbot
Copy link
Member Author

llvmbot commented Nov 8, 2018

r345353 fixes a regression in v7.0, which makes JumpThreading take an unacceptable amount of time on some inputs.

Relevant bug: #37277
Review link: https://reviews.llvm.org/D53245

@llvmbot
Copy link
Member Author

llvmbot commented Nov 8, 2018

Rewording:

r345353 fixes a regression which makes JumpThreading take an unacceptable amount of time on some inputs in v7.0.

@tstellar
Copy link
Collaborator

Jakub,

You reviewed this patch, what do you think about merging this?

@kuhar
Copy link
Member

kuhar commented Nov 16, 2018

This should be safe to merge, I don't know of any regression caused by the patch, while it solves some known (slowness) bugs.

@tstellar
Copy link
Collaborator

Merged: r347285

@tstellar tstellar mentioned this issue Sep 27, 2018
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuhar kuhar

Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstellar @kuhar @llvmbot