Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge debug-experience fixes into 7.0.1 branch #39039

Closed
jmorse opened this issue Nov 16, 2018 · 5 comments
Closed

Merge debug-experience fixes into 7.0.1 branch #39039

jmorse opened this issue Nov 16, 2018 · 5 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla

Comments

@jmorse
Copy link
Member

jmorse commented Nov 16, 2018

Bugzilla Link 39691
Resolution FIXED
Resolved on Nov 30, 2018 09:55
Version 7.0
OS Linux
Blocks #38454
CC @gregbedwell,@pogo59,@pogo59,@tstellar
Fixed by commit(s) r344589 r348011

Extended Description

Hi, could we merge the following debug-info patches into the 7.0.1 release? They're all small-scope independent patches fixing bad debug experiences such as presenting illegal variable values or stepping onto unreachable lines.

svn bugzilla Phab-review
r345996 38952 https://reviews.llvm.org/D53992
r344589 39019 https://reviews.llvm.org/D53130
r343445 38773 https://reviews.llvm.org/D52614
r342527 38763 https://reviews.llvm.org/D51976
r345250 38762 https://reviews.llvm.org/D53287

(While the patches are independent of other changes, r345250 depends on r342527 due to the use of dropDebugUsers).

@jmorse
Copy link
Member Author

jmorse commented Nov 16, 2018

assigned to @echristo

@tstellar
Copy link
Collaborator

Hi Eric,

Are these OK to merge?

@echristo
Copy link
Contributor

Should be ok.

@jmorse
Copy link
Member Author

jmorse commented Nov 26, 2018

Apologies, it looks like I didn't properly check that these apply cleanly -- as it stands, just r344589 will apply cleanly by itself, my mistake.

It's no big deal if the others are dropped, they're all small improvements.

@tstellar
Copy link
Collaborator

Merged: r348011

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

3 participants