Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvaluateTemporary: Assertion `E->isPRValue() && E->getType()->isRecordType()' failed. #53741

Open
zhouzhouyi-hub opened this issue Feb 11, 2022 · 3 comments
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" confirmed Verified by a second party crash Prefer [crash-on-valid] or [crash-on-invalid]

Comments

@zhouzhouyi-hub
Copy link
Contributor

zhouzhouyi-hub commented Feb 11, 2022

When compile following code, The Assertion in EvaluateTemporary will fail.

typedef bool Var;
bool foobool() {
return (bool().Var::~Var(), false);
}

command line:
clang++ -S -emit-llvm -Xclang -disable-llvm-passes crash.C

my fix of it:
https://reviews.llvm.org/D119493

@EugeneZelenko EugeneZelenko added clang:frontend Language frontend issues, e.g. anything involving "Sema" and removed new issue labels Feb 11, 2022
@llvmbot
Copy link
Member

llvmbot commented Feb 11, 2022

@llvm/issue-subscribers-clang-frontend

@JOE1994
Copy link
Member

JOE1994 commented Nov 26, 2024

Reproducible with clang 19.1.0 (assertions enabled) : https://godbolt.org/z/PvcoarP1d

@EugeneZelenko EugeneZelenko added confirmed Verified by a second party crash Prefer [crash-on-valid] or [crash-on-invalid] labels Nov 26, 2024
@shafik
Copy link
Collaborator

shafik commented Dec 6, 2024

So it looks like this is the only place we don't validate the assertions in EvaluateTemporary():

if (Object->getType()->isLiteralType(Info.Ctx))
return EvaluateTemporary(Object, This, Info);

So maybe we need to adjust the assert to be or isLiteralType()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" confirmed Verified by a second party crash Prefer [crash-on-valid] or [crash-on-invalid]
Projects
None yet
Development

No branches or pull requests

5 participants