Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc++] std::fpclassify() on non-floats that are convertible to float is an error? #54356

Closed
LebedevRI opened this issue Mar 12, 2022 · 7 comments
Closed

[libc++] std::fpclassify() on non-floats that are convertible to float is an error? #54356

LebedevRI opened this issue Mar 12, 2022 · 7 comments
Assignees
@tolikmalibroda
Labels
confirmed Verified by a second party good first issue https://github.com/llvm/llvm-project/contribute libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. rejects-valid

Comments

@LebedevRI
Copy link
Member

I don't know if this is a bug, but it's an inconsistency with libstdc++:
https://godbolt.org/z/dKGxhndEj
@LebedevRI LebedevRI added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 12, 2022
@LebedevRI LebedevRI mentioned this issue Mar 12, 2022
Merged
@philnik777 philnik777 added the confirmed Verified by a second party label Mar 16, 2022
@philnik777
Copy link
Contributor

This should indeed be implicitly converted to double according to http://eel.is/c++draft/cmath.syn.

@frederick-vs-ja
Copy link
Contributor

LWG3693 may be related.

@philnik777 philnik777 added rejects-valid good first issue https://github.com/llvm/llvm-project/contribute labels Jul 15, 2023
@llvmbot
Copy link
Member

llvmbot commented Jul 16, 2023

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Assign the issue to you.
  2. Fix the issue locally.
  3. Run the test suite locally.
    3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can
    e.g. use make check-clang-ast to only run Clang's AST tests.
  4. Create a git commit
  5. Run git clang-format HEAD~1 to format your changes.
  6. Submit the patch to Phabricator.
    6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

@llvm/issue-subscribers-good-first-issue

@tolikmalibroda
Copy link
Contributor

Is this bug still relevant? I would like to work on it

@ldionne
Copy link
Member

ldionne commented Sep 25, 2023

Is this bug still relevant? I would like to work on it

Yes, I think it's still relevant! It'd be great if you can work on a PR for it, let us know once you have something!

@tolikmalibroda
Copy link
Contributor

Created PR: #67913

@ldionne
Copy link
Member

ldionne commented Oct 5, 2023

Closing since #67913 was merged.

@ldionne ldionne closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tolikmalibroda tolikmalibroda

Labels
confirmed Verified by a second party good first issue https://github.com/llvm/llvm-project/contribute libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. rejects-valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@LebedevRI @ldionne @frederick-vs-ja @philnik777 @tolikmalibroda @llvmbot