Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for __unw_add_dynamic_eh_frame_section in non-ORC-runtime exception registration paths. #55681

Open
lhames opened this issue May 24, 2022 · 2 comments
Labels
good first issue https://github.com/llvm/llvm-project/contribute orcjit

Comments

@lhames
Copy link
Contributor

lhames commented May 24, 2022

Background:

LLVM JIT clients using libunwind on Linux have historically encountered "FDE is really a CIE" errors and associated issues with exception handling (see e.g. #86).

To address these issues @housel added new dynamic registration functions for eh-frame-sections to libunwind in bab3981 (__unw_add_dynamic_eh_frame_section registers a section, __unw_remove_dynamic_eh_frame_section deregisters it), and updated the ORC runtime was updated to check for and use these registration functions in 981523b.

@housel's patch fixes the issue for JIT clients who use the ORC runtime, but the LLVM-only registration paths are still hardcoded to use the __register_frame and __deregister_frame functions. We should update the LLVM-only paths to check and use these functions too.

@lhames lhames added orcjit good first issue https://github.com/llvm/llvm-project/contribute labels May 24, 2022
@llvmbot
Copy link
Member

llvmbot commented May 24, 2022

@llvm/issue-subscribers-orcjit

@llvmbot
Copy link
Member

llvmbot commented May 24, 2022

@llvm/issue-subscribers-good-first-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue https://github.com/llvm/llvm-project/contribute orcjit
Projects
None yet
Development

No branches or pull requests

2 participants