Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DirectX backend] remove unused resource and update ID for rest resources #58344

Closed
python3kgae opened this issue Oct 13, 2022 · 1 comment
Closed

[DirectX backend] remove unused resource and update ID for rest resources #58344

python3kgae opened this issue Oct 13, 2022 · 1 comment
Labels
backend:DirectX question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!

Comments

@python3kgae
Copy link
Contributor

After optimizations, some resources in the resource table might be useless.
We should remove these unused resources from the resource table and update the resource ID for the rest of the resources.
@python3kgae python3kgae moved this to In Progress in HLSL Support Oct 19, 2022
@python3kgae python3kgae self-assigned this Oct 19, 2022
@python3kgae python3kgae moved this from In Progress to Needs Review in HLSL Support Oct 27, 2022
@llvm-beanz llvm-beanz removed the status in HLSL Support Sep 7, 2023
@bogner
Copy link
Contributor

bogner commented Jun 17, 2024

Numbering resource IDs will be done when lowering to createHandle calls in #91366 and #91406. Since the IDs won't exist until lowering there won't be anything we need to renumber.

@bogner bogner closed this as completed Jun 17, 2024
@EugeneZelenko EugeneZelenko added the question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead! label Jun 17, 2024
@bogner bogner closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend:DirectX question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!
Projects
HLSL Support
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bogner @EugeneZelenko @python3kgae