llvm-windres handling of unescaped quotes broke building xz #65122
Labels
llvm-tools
All llvm tools that do not have corresponding tag
regression
release:backport
release:merged
Milestone
The recent change (in 17.x) for llvm-windres handling of unescaped quotes in 0f4c6b1 (which in itself fixed one aspect of #57334) instead broke use of llvm-windres in building xz (an llvm-windres specific workaround in tukaani-project/xz@6b117d3, which worked before no longer works with the current llvm-windres).
We shouldn't be trading one bug for another, as the change from 0f4c6b1 is correct in itself (making llvm-windres behaviour closer to GNU windres), we can implement the GNU windres flag
--use-temp-file
properly, which should allow the GNU windres codepath in xz to work for llvm-windres as well.A "fix" for this issue is up at https://reviews.llvm.org/D159223 - but to properly take that fix into use, xz will need to remove its llvm-windres specific handling.
The text was updated successfully, but these errors were encountered: