Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildbot could run builds on a single worker in order different to the order of commits #219

Open
gkistanova opened this issue Jul 2, 2024 · 1 comment

Comments

@gkistanova
Copy link
Contributor

Here is the example of such case. The order of these two builds should be the other way around:
https://lab.llvm.org/buildbot/#/builders/56/builds/1451
https://lab.llvm.org/buildbot/#/builders/56/builds/1452

Originally reported by @nikic - https://discourse.llvm.org/t/buildbot-started-commenting-prs-on-buid-failures/79738/13

@slydiman
Copy link
Contributor

slydiman commented Jul 6, 2024

The gitpoller added changes and triggers the changes new event. The change record contains the correct timestamp in when_timestamp but it is not used anywhere. A scheduler calls addBuildsetForChanges() and finally addBuildset() in buildbot/master/buildbot/data/buildsets.py uses the current time for submitted_at. A lot of buildrequests may be added with the same submitted_at. It would be great to use when_timestamp as submitted_at.
BuildChooserBase._fetchUnclaimedBrdicts() sorts brdicts by submitted_at and the order is undefined in case of the same submitted_at for few buildrequest.

The BuildChooserBase sorts by buildrequestid instead of submitted_at since v3.10.0.
It seems it is necessary to update the buildbot to v3.10.0 at least or apply the patch
buildbot/buildbot@9b84a03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants