-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
globalThis obviates the need for any shmiming on the user's part. #74
Comments
How do you propose that we allow the specification of the scratch directory that the LocalStorage class needs upon instantiation? Right now, when you shim it in, you get a chance to specify that. |
Have a sensible default (e..g. |
I think pretty much any OS has functions for create temp directories and files. |
Is anyone still interested in this change. Seems pretty easy and reasonable? |
ES6 introduced
globalThis
, which is supported by all LTS versions of Node (support was added in v12, the oldest still available LTS version) and obviates the need for users to write their own shims. The library itself can test whetherglobalThis.localStorage
exists, and if not, create it. As this is the true global scope,localStorage
can now be called (without prefix) anywhere, just likerequire()
,process
, etc. etc.The text was updated successfully, but these errors were encountered: