Skip to content

Commit 00687a4

Browse files
committed
Feat: Add NoUnneededImportAliasFixer (part of #94)
1 parent f36ad7f commit 00687a4

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

ecs.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
use PhpCsFixer\Fixer\FunctionNotation\ReturnTypeDeclarationFixer;
7777
use PhpCsFixer\Fixer\FunctionNotation\VoidReturnFixer;
7878
use PhpCsFixer\Fixer\Import\NoLeadingImportSlashFixer;
79+
use PhpCsFixer\Fixer\Import\NoUnneededImportAliasFixer;
7980
use PhpCsFixer\Fixer\Import\NoUnusedImportsFixer;
8081
use PhpCsFixer\Fixer\Import\OrderedImportsFixer;
8182
use PhpCsFixer\Fixer\LanguageConstruct\DeclareEqualNormalizeFixer;
@@ -281,13 +282,15 @@
281282
ReturnTypeDeclarationFixer::class,
282283

283284
VoidReturnFixer::class,
284-
285+
// Remove leading slashes in `use` clauses.
285286
NoLeadingImportSlashFixer::class,
286-
287+
// Imports should not be aliased as the same name.
288+
NoUnneededImportAliasFixer::class,
289+
// Unused `use` statements must be removed.
287290
NoUnusedImportsFixer::class,
288-
291+
// Order `use` statements.
289292
OrderedImportsFixer::class,
290-
293+
// Equal sign in declare statement should not be surrounded by spaces.
291294
DeclareEqualNormalizeFixer::class,
292295
// Replaces `is_null($var)` expression with `null === $var`
293296
IsNullFixer::class,

tests/Integration/Fixtures/Basic.correct.php.inc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php declare(strict_types=1);
22

3+
use Bar\Foo; // NoUnneededImportAliasFixer
4+
35
class Basic
46
{
57
public const FOO = 'foo'; // ClassAttributesSeparationFixer
@@ -20,6 +22,9 @@ class Basic
2022
$className = DateTime::class;
2123
// ClassReferenceNameCasingFixer
2224
$date = new \DateTime();
25+
26+
$aliasedClass = new Foo();
27+
2328
// SingleSpaceAfterConstructFixer, StrictComparisonFixer
2429
if ($a === $b || $bazLength !== 3) {
2530
return true;

tests/Integration/Fixtures/Basic.wrong.php.inc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
use Bar\Foo as Foo; // NoUnneededImportAliasFixer
4+
35
class Basic
46
{
57
const FOO = 'foo'; // ClassAttributesSeparationFixer
@@ -19,6 +21,9 @@ class Basic
1921
$className = DateTime :: class;
2022
// ClassReferenceNameCasingFixer
2123
$date = new \datetime();
24+
25+
$aliasedClass = new Foo();
26+
2227
// SingleSpaceAfterConstructFixer, StrictComparisonFixer
2328
if ($a == $b || $bazLength != 3) { return true; }
2429
return false; // BlankLineBeforeStatementFixer

0 commit comments

Comments
 (0)