Fix(web-twig): Fix condition to render aria-labelledby attribute in…

… the Modal component
lmc-eu · Aug 14, 2023 · 70fb37b · 70fb37b
1 parent d7480a5
commit 70fb37b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/web-twig/src/Resources/components/Modal/Modal.twig b/packages/web-twig/src/Resources/components/Modal/Modal.twig
@@ -8,7 +8,7 @@
 
 {# Attributes #}
 {%- set _idAttr = _id ? 'id="' ~ _id | escape('html_attr') ~ '"' : null -%}
-{%- set _ariaLabelledbyAttr = _id ? 'aria-labelledby="' ~ _titleId | escape('html_attr') ~ '"' : null -%}
+{%- set _ariaLabelledbyAttr = _titleId ? 'aria-labelledby="' ~ _titleId | escape('html_attr') ~ '"' : null -%}
 
 {# Miscellaneous #}
 {%- set _styleProps = useStyleProps(props) -%}

diff --git a/.../tests/__snapshots__/ComponentsSnapshotTest__test with data set modalDefault.twig__1.html b/.../tests/__snapshots__/ComponentsSnapshotTest__test with data set modalDefault.twig__1.html
@@ -5,7 +5,7 @@
     </title>
   </head>
   <body>
-    <dialog aria-label="Modal Title" class="Modal" id="modal-example-mini" aria-labelledby="">
+    <dialog aria-label="Modal Title" class="Modal" id="modal-example-mini">
       <article class="ModalDialog ModalDialog--expandOnMobile">
         <header class="ModalHeader">
           <button aria-controls="modal-example-mini" aria-expanded="false" data-spirit-dismiss="modal" data-spirit-target="#modal-example-mini" class="Button Button--tertiary Button--medium Button--square" type="button"><svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewbox="0 0 24 24" fill="none" id="a79dff7a255f69bbe6e39d594aa2275b" aria-hidden="true">