Fix(web-twig): Deprecated size prop on Icon cannot modify dimensions

refs #DS-600
lmc-eu · Feb 13, 2023 · dc94695 · dc94695
1 parent 061fad2
commit dc94695
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/web-twig/src/Resources/components/Icon/Icon.twig b/packages/web-twig/src/Resources/components/Icon/Icon.twig
@@ -4,8 +4,8 @@
 {%- set _class = props.class | default(null) -%}
 {%- set _isReusable = props.isReusable ?? true -%}
 {%- set _name = props.name -%}
-{%- set _boxSize = props.size | default('24') -%}
-{%- set _size = props.size -%}
+{%- set _boxSize = props.boxSize | default('24') -%}
+{%- set _size = props.size | default(null) -%}
 {%- set _title = props.title | default(null) -%}
 
 {# Miscellaneous #}

diff --git a/.../tests/__snapshots__/ComponentsSnapshotTest__test with data set alertDefault.twig__1.html b/.../tests/__snapshots__/ComponentsSnapshotTest__test with data set alertDefault.twig__1.html
@@ -25,7 +25,8 @@
 </div>
 </div>
 <div class="Alert Alert--warning" role="alert">
-  <svg width="24" height="24" fill="none" viewbox="0 0 24 24" aria-hidden="true"><use href="#71b5e17370f608a6d61d19a2af18fcf8"></use></svg>
+
+<svg width="24" height="24" fill="none" viewbox="0 0 24 24" aria-hidden="true"><use href="#71b5e17370f608a6d61d19a2af18fcf8"></use></svg>
 
   <div>    Message
 </div>

diff --git a/...g/tests/__snapshots__/ComponentsSnapshotTest__test with data set iconDefault.twig__1.html b/...g/tests/__snapshots__/ComponentsSnapshotTest__test with data set iconDefault.twig__1.html
@@ -9,7 +9,7 @@
 <title>This is warning!</title></svg>
 
 
-<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewbox="0 0 24 24" fill="none" id="c51fe06cfa0bbc05bf3181d59095e0c5" aria-hidden="true">
+<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewbox="0 0 24 24" fill="none" id="e39023c98e31505f72680c1b01f89296" aria-hidden="true">
 <path d="M2.73041 21.0001H21.2604C22.0304 21.0001 22.5104 20.1701 22.1304 19.5001L12.8604 3.50006C12.4704 2.83006 11.5104 2.83006 11.1304 3.50006L1.86041 19.5001C1.48041 20.1701 1.96041 21.0001 2.73041 21.0001ZM13.0004 18.0001H11.0004V16.0001H13.0004V18.0001ZM12.0004 14.0001C11.4504 14.0001 11.0004 13.5501 11.0004 13.0001V11.0001C11.0004 10.4501 11.4504 10.0001 12.0004 10.0001C12.5504 10.0001 13.0004 10.4501 13.0004 11.0001V13.0001C13.0004 13.5501 12.5504 14.0001 12.0004 14.0001Z" fill="#132930"></path>
 <title>This is warning!</title></svg>