Enable almost all tc39 tests #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1816 +/- ##
=======================================
Coverage 71.58% 71.58%
=======================================
Files 181 181
Lines 13939 13939
=======================================
Hits 9978 9978
Misses 3328 3328
Partials 633 633
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mstoykov
force-pushed
the
enableAlmostAllTc39Tests
branch
from
9898351 to
eaea04d
Compare
|
Please go commit by commit ;) |
mstoykov
force-pushed
the
enableAlmostAllTc39Tests
branch
from
351500b to
928e730
Compare
imiric
previously approved these changes
Jan 27, 2021
| for _, path := range pathBasedBlock { // TODO: use trie / binary search? | ||
| if strings.HasPrefix(newName, path) { | ||
| ctx.t.Run(newName, func(t *testing.T) { | ||
| t.Skipf("Skip %s beause of path based block", newName) |
There was a problem hiding this comment.
Suggested change
| t.Skipf("Skip %s beause of path based block", newName) | |
| t.Skipf("Skipped %s because of path based block", newName) |
na--
previously approved these changes
Feb 1, 2021
mstoykov
force-pushed
the
enableAlmostAllTc39Tests
branch
from
5474050 to
b71ee6d
Compare
na--
previously approved these changes
Feb 1, 2021
mstoykov
force-pushed
the
enableAlmostAllTc39Tests
branch
from
b71ee6d to
97689ae
Compare
git only tracks diffs ... so this is barely a problem, especially given the size of the |
na--
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.