Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] cz-emoji support #37

Open
Kristinita opened this issue Jan 29, 2018 · 2 comments
Open

[Feature request] cz-emoji support #37

Kristinita opened this issue Jan 29, 2018 · 2 comments

Comments

@Kristinita
Copy link

1. Request

It would be nice, if generate-changelog will support cz-emoji.

2. Justification

Support smiles in commit messages. cz-emoji — commitizen-compatible npm package.

3. Steps to reproduce

I install commitizen and cz-emoji → I create any commit to my GitHub repository via cz-emoji → I run command changelog -f -.

4. Expected behavior

Successful changelog generation.

5. Actual behavior

Blank changelog, example:

D:\SashaBranchReleaseIt>changelog -f -
#### 2.0.1 (2018-01-29)

Thanks.

@dmlittle
Copy link
Contributor

Hi @Kristinita, I'm unable to reproduce the issue. Could this be a problem with your environment not being able to display emoji correctly in the shell? I just tested the latest version of generate-changelog in a new, empty repo with emojis in the commit message and it works just fine.

$ yarn add generate-changelog
yarn add v0.27.5
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
warning Your current version of Yarn is out of date. The latest version is "1.3.2" while you're on "0.27.5".
success Saved 4 new dependencies.
├─ bluebird@3.5.1
├─ commander@2.13.0
├─ generate-changelog@1.7.0
└─ github-url-from-git@1.5.0
Done in 0.74s.
$ git init
Initialized empty Git repository in /private/tmp/emoji-test/.git/
$ git commit -m 'feat(emoji): 🌟 🐞' --allow-empty
[master (root-commit) 7e3f207] feat(emoji): 🌟 🐞
$ git log
commit 7e3f207188f9c2dddf4e63b085a6f2bd24aaca0b
Author: Donald Little <donald@lob.com>
Date:   Mon Jan 29 12:08:33 2018 -0800

    feat(emoji): 🌟 🐞
$ ./node_modules/generate-changelog/bin/generate --major
$ cat CHANGELOG.md
## 2018-01-29

##### New Features

* **emoji:**  🌟 🐞 (7e3f2071)

@Kristinita
Copy link
Author

Kristinita commented Jan 30, 2018

@dmlittle, my request not about emoji at all, it about cz-emoji. Do you try reproduce issue, use cz-emoji?

Steps to reproduce

My C:\Users\SashaChernykh\.czrc file:

{ "path": "cz-conventional-changelog", "path": "cz-emoji"}

I run in my git repository folder:

# I make any changes in my repository
D:\SashaBranchReleaseIt>git add .

D:\SashaBranchReleaseIt>git cz
cz-cli@2.9.6, cz-emoji@1.1.0

? Select the type of change you're committing: fix          🐛  Fixing a bug.
? Specify a scope: examplescope
? Write a short description: Short
? List any issue closed (#1, …):
? Provide a longer description: Longer description
[master 3f494ba] :bug: (examplescope) Short
 1 file changed, 2 insertions(+), 1 deletion(-)

D:\SashaBranchReleaseIt>changelog -f -
#### 2.0.1 (2018-01-30)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants