Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMIT_EDITMSG is not updated #53

Open
egeshi opened this issue Jul 10, 2019 · 0 comments
Open

COMMIT_EDITMSG is not updated #53

egeshi opened this issue Jul 10, 2019 · 0 comments

Comments

@egeshi
Copy link

egeshi commented Jul 10, 2019

Hello guys and thank you for a wonderful package!

I am experiencing some issues though if running commit from within a submodule directory.

(node:16959) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: ENOTDIR: not a directory, open '/home/ubuntu/path/to/repository/submodule/.git/COMMIT_EDITMSG' [edited for bug report]
(node:16959) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Nonetheless I believe that script is right because hooks for submodules are located under ../.git/modules/submodule/hooks and therefore COMMIT_EDITMSG file would never appear under submodule/.git/COMMIT_EDITMSG and submodule/.git is file, that's true as well ;)

I cannot give a time to resolve it by myself at the moment but will hopefully provide a solution somehow later as a contributor.

Forgot to add. I am using generate-changelog together with commitizen so it may not be a bug in generate-changelog at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant