-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: clerk appearance is not applied #3105
Conversation
@phuctm97 is attempting to deploy a commit to the LobeHub Pro Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3105 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 388 388
Lines 23968 23968
Branches 1767 1766 -1
=======================================
Hits 22470 22470
Misses 1498 1498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think it's a good way to solve the issue that clerk provider introduce. But I wonder if there is any possible that Clerk solve this problem at their side? Or in another words, when can we remove these codes? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I reported this issue to them. Hopefully they'll fix it soon. The code only re-renders the clerk provider once, it shouldn't a problem regardless imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine as a fix at our side now. I hope we can remove this part if the Clerk side solve the issue.
❤️ Great PR @phuctm97 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.2.5](v1.2.4...v1.2.5) <sup>Released on **2024-07-02**</sup> #### 🐛 Bug Fixes - **misc**: Fix clerk appearance is not applied correctly. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix clerk appearance is not applied correctly, closes [#3105](#3105) ([cf9c145](cf9c145)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
🎉 This PR is included in version 1.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
### [Version 1.45.3](v1.45.2...v1.45.3) <sup>Released on **2024-07-02**</sup> #### 🐛 Bug Fixes - **misc**: Fix clerk appearance is not applied correctly. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix clerk appearance is not applied correctly, closes [lobehub#3105](https://github.com/bentwnghk/lobe-chat/issues/3105) ([cf9c145](cf9c145)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
### [Version 1.2.5](lobehub/lobe-chat@v1.2.4...v1.2.5) <sup>Released on **2024-07-02**</sup> #### 🐛 Bug Fixes - **misc**: Fix clerk appearance is not applied correctly. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix clerk appearance is not applied correctly, closes [lobehub#3105](lobehub#3105) ([cf9c145](lobehub@cf9c145)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
When
useAppearance
returns different result during SSR vs. client-side (when theme mode is auto), the appearance is not applied. It's because Clerk internally re-applies SSR props after transition which overrides client-side props, see https://github.com/clerk/javascript/blob/main/packages/nextjs/src/app-router/client/ClerkProvider.tsx. This re-renders the provider after transition to make sure client-side props are always applied.