Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Enabled function calling on Deepseek models #3312

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

ZachZimm
Copy link
Contributor

@ZachZimm ZachZimm commented Jul 25, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

The Deepseek API supports function calling and I tested to make sure it works.

📝 补充信息 | Additional Information

This pull request is meant to address Issue, close #3310
Unsurprisingly the DALLE plugin does not work, although I did not test with an OpenAI key.

Copy link

vercel bot commented Jul 25, 2024

@ZachZimm is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @ZachZimm

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (5f4491a) to head (bac483e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3312    +/-   ##
========================================
  Coverage   94.18%   94.18%            
========================================
  Files         398      398            
  Lines       24893    24895     +2     
  Branches     2884     2698   -186     
========================================
+ Hits        23445    23447     +2     
  Misses       1448     1448            
Flag Coverage Δ
app 94.18% <100.00%> (+<0.01%) ⬆️
server 68.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 4:10pm

@jueinin
Copy link

jueinin commented Jul 25, 2024

支持不支持,为啥是写死的,我要是one api 中转换个名字啥的,就没法用了,难顶

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Is it supported or not? Why is it hard-coded? If I change a name or something in One API, it won’t work. It’s hard to explain.

@ZachZimm
Copy link
Contributor Author

支持不支持,为啥是写死的,我要是one api 中转换个名字啥的,就没法用了,难顶

The way that lobe-hub is set up, yes it is hard-coded whether each model can use tools. Until that provider gets the ability to fetch model details over the API. Function calling is supported by Deepseek AI (docs).

@ZachZimm ZachZimm changed the title Enabled function calling on Deepseek models ✨ feat: Enabled function calling on Deepseek models Jul 25, 2024
@arvinxx arvinxx merged commit 35f31cb into lobehub:main Jul 26, 2024
8 of 9 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @ZachZimm ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
## [Version&nbsp;1.7.0](v1.6.15...v1.7.0)
<sup>Released on **2024-07-26**</sup>

#### ✨ Features

- **misc**: Enabled function calling on Deepseek models.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Enabled function calling on Deepseek models, closes [#3312](#3312) ([35f31cb](35f31cb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 26, 2024
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 26, 2024
## [Version&nbsp;1.7.0](lobehub/lobe-chat@v1.6.15...v1.7.0)
<sup>Released on **2024-07-26**</sup>

#### ✨ Features

- **misc**: Enabled function calling on Deepseek models.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Enabled function calling on Deepseek models, closes [lobehub#3312](lobehub#3312) ([35f31cb](lobehub@35f31cb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 26, 2024
## [Version&nbsp;1.50.0](v1.49.10...v1.50.0)
<sup>Released on **2024-07-26**</sup>

#### ✨ Features

- **misc**: Enabled function calling on Deepseek models.

#### 💄 Styles

- **misc**: Fix file upload height.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **misc**: Enabled function calling on Deepseek models, closes [lobehub#3312](https://github.com/bentwnghk/lobe-chat/issues/3312) ([35f31cb](35f31cb))

#### Styles

* **misc**: Fix file upload height, closes [lobehub#3319](https://github.com/bentwnghk/lobe-chat/issues/3319) ([8343f35](8343f35))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] deepseek-chat 和 deepseek-coder 已支持 function call
4 participants